Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make a governance parameter for Ethereum events minimum confirmations #562

Closed
james-chf opened this issue Oct 7, 2022 · 1 comment
Closed

Make a governance parameter for Ethereum events minimum confirmations #562

james-chf opened this issue Oct 7, 2022 · 1 comment
Assignees
@james-chf
Labels
ethereum-bridge good first issue Good for newcomers ledger

Comments

@james-chf
Copy link
Contributor

james-chf commented Oct 7, 2022 •
edited
Loading

Currently this is a hardcoded constant (100)

namada/apps/src/lib/node/ledger/ethereum_node/oracle.rs

Lines 16 to 17 in 85d5542

/// Minimum number of confirmations needed to trust an Ethereum branch
pub(crate) const MIN_CONFIRMATIONS: u64 = 100;

@james-chf james-chf moved this to Todo in Namada-Old Oct 7, 2022
@james-chf james-chf changed the title Make a governance parameter for the Ethereum events minimum confirmations Make a governance parameter for Ethereum events minimum confirmations Oct 7, 2022
@james-chf james-chf added the good first issue Good for newcomers label Oct 7, 2022
@james-chf james-chf self-assigned this Oct 10, 2022
@james-chf james-chf moved this from Todo to WIP in Namada-Old Oct 10, 2022
This was referenced Oct 10, 2022
Merged
Closed
@james-chf
Copy link
Contributor Author

Will start being used in #686

Repository owner moved this from WIP to Tested in Devnet in Namada-Old Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@james-chf james-chf

Labels
ethereum-bridge good first issue Good for newcomers ledger
Projects
No open projects
Namada-Old
Status: Tested in Devnet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@james-chf