Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable custom wasm code execution in the RPC #2815

Closed
2 tasks
sug0 opened this issue Mar 5, 2024 · 3 comments
Closed
2 tasks

Disable custom wasm code execution in the RPC #2815

sug0 opened this issue Mar 5, 2024 · 3 comments
Labels
pre-mainnet Must happen before mainnet. security

Comments

@sug0
Copy link
Collaborator

sug0 commented Mar 5, 2024

  • Disable custom wasm execution in dry ran txs.
  • Remove TxCustom from the sdk args.
@sug0 sug0 added security pre-mainnet Must happen before mainnet. labels Mar 5, 2024
@sug0 sug0 changed the title Disable custom wasm code execution Disable custom wasm code execution in the RPC Mar 8, 2024
@brentstone brentstone added this to the To evaluate milestone Apr 10, 2024
@cwgoes
Copy link
Collaborator

cwgoes commented Apr 23, 2024

@Fraccaman to ask @sug0

@sug0
Copy link
Collaborator Author

sug0 commented Apr 24, 2024

@cwgoes @Fraccaman this issue was created before we had gas metering at the instruction level in wasm. this allowed you to submit transactions with infinite loops, DoSing the node you submitted the tx to; now, you'll eventually run out of gas, when dry running a tx with an infinite loop. I think it's fine to allow the execution of arbitrary wasms in the RPC, which might be useful to estimate the gas cost of a governance proposal. most nodes will probably want to disable this functionality, though, since it might have a significant CPU cost

@Fraccaman
Copy link
Member

perfect thanks! Ill close this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-mainnet Must happen before mainnet. security
Projects
None yet
Development

No branches or pull requests

4 participants