Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Ethereum Bridge code #2598

Closed
5 tasks done
Tracked by #2564
sug0 opened this issue Feb 12, 2024 · 3 comments · Fixed by #2602
Closed
5 tasks done
Tracked by #2564

Disable Ethereum Bridge code #2598

sug0 opened this issue Feb 12, 2024 · 3 comments · Fixed by #2602
Assignees
@sug0
Labels
ethereum-bridge pre-mainnet Must happen before mainnet.
Milestone
Phase 1: mainnet ...

Comments

@sug0
Copy link
Collaborator

sug0 commented Feb 12, 2024 •
edited
Loading

Disable all Ethereum bridge functionality at compile time. We can keep its implementation in the codebase, and still compile it, but it should never be reachable by the node.

  • Reject validator set updates.
  • Reject Ethereum event vote extensions.
  • Reject Bridge pool root signature vote extensions.
  • Disable Bridge pool txs.
  • Disable Ethereum bridge related CLI commands at compile time.
@sug0 sug0 mentioned this issue Feb 12, 2024
Closed
3 tasks
@sug0 sug0 changed the title Disable all Ethereum bridge code (don't run the broadcaster). We can keep the code in the codebase, and still compile it, but it should never be called by the node. Disable Ethereum Bridge code Feb 12, 2024
@sug0 sug0 self-assigned this Feb 12, 2024
@Fraccaman
Copy link
Member

can we also disable the commands from the cli?

@sug0
Copy link
Collaborator Author

sug0 commented Feb 12, 2024

should be possible yeah

@sug0 sug0 mentioned this issue Feb 12, 2024
Merged
2 tasks
@sug0 sug0 added the pre-mainnet Must happen before mainnet. label Feb 12, 2024
@Rigorously Rigorously mentioned this issue Feb 12, 2024
Closed
@sug0 sug0 mentioned this issue Feb 19, 2024
Open
@brentstone brentstone added this to the Phase 1: mainnet genesis milestone Apr 6, 2024
@chimmykk chimmykk mentioned this issue Apr 9, 2024
Closed
3 tasks
@chimmykk
Copy link

chimmykk commented Apr 9, 2024

#3036

Removed ETH-bridge-pool cli commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sug0 sug0

Labels
ethereum-bridge pre-mainnet Must happen before mainnet.
Projects
None yet
Milestone
Phase 1: mainnet genesis
4 participants
@Fraccaman @sug0 @brentstone @chimmykk