Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the ability to update an account's VP #2554

Closed
Tracked by #2529
cwgoes opened this issue Feb 7, 2024 · 4 comments
Closed
Tracked by #2529

Remove the ability to update an account's VP #2554

cwgoes opened this issue Feb 7, 2024 · 4 comments
Assignees
Labels
pre-mainnet Must happen before mainnet. security

Comments

@cwgoes
Copy link
Collaborator

cwgoes commented Feb 7, 2024

We do not need the ability for an account to update their VP in the initial version of Namada, and we should remove it.

@grarco
Copy link
Collaborator

grarco commented Feb 8, 2024

Should we also remove the vp hash from InitAccount and just assign the default vp_user to all the established addresses?

@cwgoes
Copy link
Collaborator Author

cwgoes commented Feb 8, 2024

Should we also remove the vp hash from InitAccount and just assign the default vp_user to all the established addresses?

Yes. Good catch.

@brentstone brentstone added this to the To evaluate milestone Apr 6, 2024
@tzemanovic
Copy link
Member

also rm the vp field from genesis::transactions::ValidatorAccountTx

@grarco
Copy link
Collaborator

grarco commented Dec 1, 2024

Closing this as it seems we don't need it anymore

@grarco grarco closed this as completed Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-mainnet Must happen before mainnet. security
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants