Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show key aliases when prompted for Multisignature Accounts passwords #2513

Closed
Tracked by #2533
Rigorously opened this issue Feb 2, 2024 · 1 comment
Closed
Tracked by #2533
Labels
enhancement New feature or request

Comments

@Rigorously
Copy link

Rigorously commented Feb 2, 2024

When interacting with Multisignature Accounts, the prompts for the decryption password are unlabeled. That could be confusing and unintuitive when some but not all signing keys are imported from another wallet. Consider the following examples:

$ namadac init-account \
--alias my-multisig-alias \
--public-keys my-key1,imported1,imported2 \
--signing-keys my-key1,imported1,imported2 \
--threshold 2
Enter your decryption password:
Enter your decryption password:

The account is initialized with 3 keys, but namadac will prompt for the 2 imported keys. The passwords have to be entered in the order in which they are present in the command.

The current behavior gives pause, because is the prompt repeated due to an incorrectly entered password? Which one has to be entered next?

$ namadac sign-tx \
--tx-path "<path-to-file>" \
--signing-keys my-key1,imported1,imported2 \
--owner my-multisig-alias
Enter your decryption password:
Enter your decryption password:
Enter your decryption password:

Namadac will prompt for all keys. The passwords have to be entered in the order in which they are present in the command.

My suggestion is to add the key aliases (or keys in the absence of aliases):

Enter decryption password for `my-key1`:
Enter decryption password for `imported1`:
Enter decryption password for `imported2`:
@cwgoes
Copy link
Collaborator

cwgoes commented Aug 27, 2024

Fixed by #3681

@cwgoes cwgoes closed this as completed Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants