Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(COMPONENT): Misnamed property for snackbar theme #29172

Closed
1 task
steveareeno opened this issue Jun 3, 2024 · 2 comments · Fixed by #29180
Closed
1 task

bug(COMPONENT): Misnamed property for snackbar theme #29172

steveareeno opened this issue Jun 3, 2024 · 2 comments · Fixed by #29180
Labels
area: material/snack-bar P2 The issue is important to a large percentage of users, with a workaround

Comments

@steveareeno
Copy link

steveareeno commented Jun 3, 2024

Is this a regression?

  • Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

No response

Description

In the node modules/@angular/material folder, the file _index.scss has a forward rule for the material UI snackbar with a misnamed property:

@forward './snack-bar/snack-bar-theme' as snack-bar-* show snack-bar-theme, snack-bar-color, snack-bar-typography, snack-bar-density, snack-bar-base, bar-overrides;

The last property, "bar-overrides", should probably be "snackbar-overrides" like all the other properties

Reproduction

StackBlitz link:
Steps to reproduce:

  1. Open the file in the @angular/material node modules folder
  2. Find the forward rule for snackbar

Expected Behavior

Expect the property to be named snackbar-bar-overrides like the other properties.

Actual Behavior

The property is named "bar-overrides"

Environment

  • Angular:
  • CDK/Material:
  • Browser(s):
  • Operating System (e.g. Windows, macOS, Ubuntu):
@steveareeno steveareeno added the needs triage This issue needs to be triaged by the team label Jun 3, 2024
@andrewseguin
Copy link
Contributor

andrewseguin commented Jun 3, 2024

Thanks, this will be fixed in #29180

@andrewseguin andrewseguin added P2 The issue is important to a large percentage of users, with a workaround area: material/snack-bar and removed needs triage This issue needs to be triaged by the team labels Jun 3, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: material/snack-bar P2 The issue is important to a large percentage of users, with a workaround
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants