Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternate way to compile non-ivy libraries after removal of ngcc in v16 #24797

Closed
1 task
iKrishnaSahu opened this issue Mar 1, 2023 · 4 comments
Closed
1 task

Comments

@iKrishnaSahu
Copy link

iKrishnaSahu commented Mar 1, 2023

Command

build

Is this a regression?

  • Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

No response

Description

Is there any alternate way to compile non-ivy packages after removal of ngcc in v16?

There are lots of unmaintained libraries like angular2-query-builder which devs are using. Till we migrated to some other library which is ivy compiled, is there any way to keep using non-ivy packages with angular v16?

Minimal Reproduction

NA

Exception or Error

No response

Your Environment

C:\Projects\projects\npm>ng version

     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/


Angular CLI: 15.1.1
Node: 16.19.0
Package Manager: npm 8.19.3
OS: win32 x64

Angular:
...

Package                      Version
------------------------------------------------------
@angular-devkit/architect    0.1501.1 (cli-only)
@angular-devkit/core         15.1.1 (cli-only)
@angular-devkit/schematics   15.1.1 (cli-only)
@schematics/angular          15.1.1 (cli-only)


C:\Projects\projects\npm>

Anything else relevant?

No response

@alan-agius4
Copy link
Collaborator

Hi, using no-Ivy libraries with version 16 will no longer be possible.

IMHO, we did give plenty of time for users to migrate to libraries using Ivy.

@alan-agius4 alan-agius4 closed this as not planned Won't fix, can't repro, duplicate, stale Mar 1, 2023
@jpike88
Copy link

jpike88 commented Mar 10, 2023

The problem is, it seems like you need a PhD to understand how to identify exactly what I have to do to upgrade a library to be Ivy-compliant. Documentation is obscure and while the implicit instruction is to just use ng-packagr, that doesn't seem to work in the below instance.

@uirouter/core contains no angular code, doesn't have any dependencies on it, doesn't expose an angular module.... yet ngcc seems to want to insist on doing something with it? Why?

ui-router/core#822

@JoostK
Copy link
Member

JoostK commented Mar 10, 2023

@jpike88 Please see ui-router/core#822 (comment) for the reason, resolution, and workaround.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants