Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

Commit

Permalink
fix(tagging): infite digest loops when name is similar
Browse files Browse the repository at this point in the history
Resolves issue where isDisabled was running for tags and causing a
infite loop to occur if the new tag value included a previous value.

For example:
  tag1: "a"
  tag2: "aa"

Fixes #1693
  • Loading branch information
user378230 committed Jul 9, 2016
1 parent b95bf9f commit fcd9bc5
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/uiSelectController.js
Original file line number Diff line number Diff line change
Expand Up @@ -351,6 +351,8 @@ uis.controller('uiSelectCtrl',

if (itemIndex >= 0 && (angular.isDefined(ctrl.disableChoiceExpression) || ctrl.multiple)) {

if (item.isTag) return false;

if (ctrl.multiple) {
isDisabled = _isItemSelected(item);
}
Expand Down

0 comments on commit fcd9bc5

Please sign in to comment.