Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ng1ViewDeclaration controller should be IInjectable #3089

Closed
FraserKillip opened this issue Oct 14, 2016 · 1 comment
Closed

Ng1ViewDeclaration controller should be IInjectable #3089

FraserKillip opened this issue Oct 14, 2016 · 1 comment
Labels
1.0 bug
Milestone
1.0.0-rc.1

Comments

@FraserKillip
Copy link

Hey,

This is similar to #3044 but seems to have been missed when applying this particular fix.

At this position https://github.com/angular-ui/ui-router/blob/master/src/ng1/interface.ts#L326 Should be IInjectible but alas, it is not.

Cheers
@christopherthielen
Copy link
Contributor

I'm fascinated by how many people are using typescript with ng1!

Thanks for the bug report.

@christopherthielen christopherthielen added this to the 1.0.0-beta.4 milestone Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.0 bug
Projects
None yet
Milestone
1.0.0-rc.1
Development

No branches or pull requests
2 participants
@FraserKillip @christopherthielen