You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 29, 2019. It is now read-only.
@Foxandxss what do you think? I could revert the breaking change, but this will be cumbersome for normal consumption & lead to hard to read strings in the HTML.
I think this is a mistake. Angular has supplied the date format syntax, this library is merely an implementation of that.
If you want to use your own format, then it would be an error to look up the date format strings from $locale. Those are angular formats, not ui-bootstrap formats.
Here is a plunkr that illustrates my problem.
All I am doing is attempting to use the date parser with 'mediumDate' as the format, while using the pt-br locale. http://plnkr.co/edit/ulvQQMc3OkET2VDfxktc
IMO I think Angular/Google got this wrong, but getting them to change it is probably not going to happen from an engineering standpoint (it would break prior contract, creating compatibility problems maintaining two different formats), so this appears that it might force us into a subpar API.
I understand your request, and we may end up reverting the change I made, I just want a second opinion since I really do not like the awkwardness of using a single quote.
I believe a recent commit broke the parsing of dates that contain quoted literals:
9513f10
Tested with the 'mediumDate' format using the portuguese locale pt-br (d 'de' MMM 'de' y HH:mm:ss)
The angular date formats use single quotes, not backticks. If you claim to support the locale base date formats, then this should be fixed.
Attn: @wesleycho
The text was updated successfully, but these errors were encountered: