Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Domain rules containing regular expressions containing the | symbol match requests incorrectly #60

Closed
anfragment opened this issue Feb 28, 2024 · 0 comments · Fixed by #61
Closed

Domain rules containing regular expressions containing the | symbol match requests incorrectly #60

anfragment opened this issue Feb 28, 2024 · 0 comments · Fixed by #61
Assignees
@anfragment
Labels
bug Something isn't working

Comments

@anfragment
Copy link
Owner

The following test needs to be fixed.

--- FAIL: TestRegex (0.00s)
    domain_test.go:106: domain=/^example\.(com|org)$/ should match a request with example.com as the referer
    domain_test.go:111: domain=/^example\.(com|org)$/ should match a request with example.org as the referer
@anfragment anfragment added the bug Something isn't working label Feb 28, 2024
@anfragment anfragment self-assigned this Feb 28, 2024
@anfragment anfragment linked a pull request Feb 28, 2024 that will close this issue
fix: fix parsing of domain modifiers containing regexes with | charac… #61
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anfragment anfragment

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix parsing of domain modifiers containing regexes with | charac… anfragment/zen
1 participant
@anfragment