-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial NFT implementation and verified distribution mechanism #6
Comments
(@andytudhope This is a very simple, single purpose issue, so it doesn't include a full server setup, or any UI on the DAPP yet. Do you prefer keeping the issues granular like this?) |
Si signor, I do indeed. Will post a relevant bounty in a moment, thanks. How long do you reckon it'll take you (in hours) @JasoonS? |
Ok great, I reckon 3 hours should be enough time, so 4 to be conservative. |
Balance: 0.000000 ETH |
Hi y'all, I've been following this project and I think we've got pretty similar ideas. Are you doing this as part of Truebit's exploration of current project pains? Also, I'd like to invite you to take a look at ethereum/EIPs#821 as a better proposal for NFTs. I see you mostly used OpenZeppelin's implementation and as "grandfather" of it I'd suggest you consider using https://github.com/decentraland/erc821 |
@eordano first off, thanks for swinging by this lowly repo :mind_blown: Am looking into your suggestions now, thank you!
Full proposal for the Status involvement with this can be found here. |
Hi @eordano, thank you, I'll definitely keep an eye on the progress of EIP821 and look into it's differences. And yes, I took that implementation from what OpenZeppelin are working on (still unpublished as far as I can see). I think we'll stick to the current implementation, and update and refactor as necessary based on conversations around EIP821 and EIP721 (You're welcome to disagree @andytudhope ). |
The purpose of this is to allow users to claim NFTs (see discussion #5) that are 'found' while exploring the artwork. The key takeaway is that the user will execute the claim themselves with an Ethereum transaction via Status, rather than having it issued to them directly.
One approach would be to use the
approveTransfer
/delegateOwner
function in the NFT standard, but this requires the server to execute a transaction first before the user can claim the token. This works fine, however it makes sense (since there is a server) to allow the server to sign this approval off chain allowing the user to claim the tokens immediately.This method will use
web3.eth.sign(account, hash)
server side, andecrecover
in the smart contract.The completion of this issue will include:
The text was updated successfully, but these errors were encountered: