Regression: crash when using the same Transformer hundreds of times

[samsonjs]

Version

Media3 1.5.1

More version details

This first showed up in 1.4.1 and I bisected that and 1.4.0 to find this commit that introduced the crash: cd2a36f

Devices that reproduce the issue

• Galaxy S22 / Android 14
• Pixel 3 / Android 12
• OnePlus 7 Pro / Android 11

Devices that do not reproduce the issue

None found

Reproducible in the demo app?

Not tested

Reproduction steps

Open this project and tap the Start Clipping button. You can watch logcat to see how many videos it processes before crashing, and it's usually by the 100 mark for me so I included 120 videos which should be enough to reproduce it.

https://drive.google.com/file/d/17riddvXjUakjOfoRcH2CtiAgxik-uBDt/view?usp=drive_link

Expected result

It should not crash

Actual result

It crashes

Media

See project here https://drive.google.com/file/d/17riddvXjUakjOfoRcH2CtiAgxik-uBDt/view?usp=drive_link

Bug Report

• You will email the zip file produced by adb bugreport to android-media-github@google.com after filing this issue.

[samsonjs]

Bug report emailed, let me know if I can provide anything else to help nail this one down.

Also we have a work-around by just creating a new Transformer instance for every video, and that's totally fine as far as I can tell. Maybe we shouldn't be re-using the same instance like this in the first place? It used to work though.