Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Videos in Timeline are not sized properly #67

Closed
calren opened this issue Apr 30, 2024 · 3 comments
Closed

Videos in Timeline are not sized properly #67

calren opened this issue Apr 30, 2024 · 3 comments
Assignees
@MayuriKhinvasara

Comments

@calren
Copy link
Collaborator

calren commented Apr 30, 2024

No description provided.

@calren
Copy link
Collaborator Author

calren commented Apr 30, 2024

After some investigation:

  • Setting the aspectRatio() is causing issues
  • We are not handling landscape vs portrait videos separately (I think we need to)
  • Not setting the aspectRatio() on the AndroidExternalSurface fixes the issue for portrait videos, but makes landscape videos look out of proportion
  • I think we need to draw different sized backgrounds for portrait / landscape videos, otherwise there will be a lot of blank space for landscape videos

@calren
Copy link
Collaborator Author

calren commented Jun 26, 2024

This may be related to android/platform-samples#172, which may be fixed in Media3 1.4.0-rc01

@calren calren mentioned this issue Jun 26, 2024
Open
@calren calren mentioned this issue Jul 12, 2024
Merged
@MayuriKhinvasara MayuriKhinvasara self-assigned this Aug 13, 2024
@calren
Copy link
Collaborator Author

calren commented Nov 12, 2024

Fixed in #91

@calren calren closed this as completed Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MayuriKhinvasara MayuriKhinvasara

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@calren @MayuriKhinvasara