-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: clang-17: error: clang frontend command failed with exit code 70 (use -v to see invocation) #1973
Comments
can repro with open source clang-trunk https://godbolt.org/z/cG1KbW38j |
See llvm/llvm-project#57069 (comment) and the following comment. The TLDR is that the ARMv7 backend doesn't tail-call-optimize if arguments are passed in stack. I mentioned this issue in that bug, but my suggested fix for now is to remove |
It is already done. Maybe it will be better to disable |
It fails in specific cases. In this case, it's because the callee has too many arguments to fit in registers. Not sure if there are other failure modes but it is expected to work in general. |
small repro
|
godbolt shows that this was true of clang 13 and 14 as well, so not a regression. From the conversation it sounds like this might be an unfriendly error message rather than a bug? Is that right? |
It's a crash instead of generating a backend diagnostic, which would be friendlier. Even better would be querying the possible maximum number of arguments for a |
Agreed 👍 |
There are two steps: (1) A helpful error message is better than a crash. This is not being pursued by anyone currently (and the priority is low). We can close this as (2) is unlikely to get fixed and (1) doesn't need to be tracked in the NDK. |
Bug: android/ndk#1728 Bug: android/ndk#1853 Bug: android/ndk#1928 Bug: android/ndk#1947 Bug: android/ndk#1953 Bug: android/ndk#1963 Bug: android/ndk#1973 Bug: android/ndk#1988 Test: ./checkbuild.py && ./run_tests.py Change-Id: Ib319c4f80c107e57ede6b6130d81d6d1cd87e22d
Description
Log
[bug.tar.gz](https://github.com/android/ndk/files/13441999/bug.tar.gz)The source can be built without problems in the case I remove all
[[clang::musttail]]
invocations.bug.tar.gz
Upstream bug
No response
Commit to cherry-pick
No response
Affected versions
r26
Canary version
No response
Host OS
Linux
Host OS version
Ubuntu 23.10
Affected ABIs
armeabi-v7a
The text was updated successfully, but these errors were encountered: