Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabbar follower doesn't return to the original position when the app goes to background #313

Closed
lawicko opened this issue Apr 17, 2018 · 2 comments

Comments

@lawicko
Copy link

lawicko commented Apr 17, 2018

Steps to reproduce:

  1. In the application with the UITabBarController as the root view controller, have AMScrollingNavbar instance in one of the tabs.
  2. Make the tab bar a follower of the scrolling navbar.
  3. Scroll the scroll view so that the navigation bar and the tab bar disappears.
  4. Make the app go to background by tapping on the home button or whatever.
  5. Come back to the app.

Expected: As in previous versions, I'd expect the tab bar becomes visible.

Actual: The tab bar stays hidden, so now there is no way to actually get the tab bar back.

Note: This bug was introduced in c382e61

@andreamazz
Copy link
Owner

Thank you @lawicko for the detective work.
I don't understand why that commit breaks the tabbar though 🤔
Any ideas?

@andreamazz
Copy link
Owner

Well, I'll cross it off as UIKit being UIKit.
Apparently a rotation is triggered when going back to foreground, and that showNavbar was required. This should be ok now, let me now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants