Skip to content

Commit

Permalink
Don’t show visual notifications when they’re turned off.
Browse files Browse the repository at this point in the history
Fixes zulip#1299.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
  • Loading branch information
andersk committed Apr 18, 2023
1 parent 0cb7297 commit 686d6d7
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion app/renderer/js/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,9 @@ export class ServerManagerView {
url: server.url,
role: "server",
hasPermission: (origin: string, permission: string) =>
origin === server.url && permission === "notifications",
origin === server.url &&
permission === "notifications" &&
ConfigUtil.getConfigItem("showNotification", true),
isActive: () => index === this.activeTabIndex,
switchLoading: async (loading: boolean, url: string) => {
if (loading) {
Expand Down

0 comments on commit 686d6d7

Please sign in to comment.