Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: zone.js import not found in versions greater than 0.13.1 #650

Closed
1 of 2 tasks
rlmestre opened this issue Sep 15, 2023 · 1 comment · Fixed by #651
Closed
1 of 2 tasks

Bug: zone.js import not found in versions greater than 0.13.1 #650

rlmestre opened this issue Sep 15, 2023 · 1 comment · Fixed by #651
Labels
bug Something isn't working

Comments

@rlmestre
Copy link
Contributor

rlmestre commented Sep 15, 2023

Please provide the environment you discovered this bug in.

M1 Mac, Node 20.5.1, zone.js 0.13.2 and 0.13.3

Which area/package is the issue in?

astro-angular

Description

Recent changes to zone.js exports and bundling are breaking the Astro integration. This happened when adding the plugin with pnpm astro add @analogjs/astro-angular because the zone.js version isn't pinned.

Please provide the exception or error you saw

✘ [ERROR] Could not resolve "zone.js/dist/zone.js"
    node_modules/@analogjs/astro-angular/src/client.js:1:7:
      1 │ import 'zone.js/dist/zone.js';
        ╵        ~~~~~~~~~~~~~~~~~~~~~~
  The module "./bundles/zone.js.umd.js" was not found on the file system:
    node_modules/zone.js/package.json:91:17:
      91 │       "default": "./bundles/*.umd.js"
         ╵                  ~~~~~~~~~~~~~~~~~~~~

Other information

Removing .js from the import fixes the issue and does not break backwards compatibility. Otherwise we could pin the version.

I would be willing to submit a PR to fix this issue

  • Yes
  • No
@rlmestre rlmestre added the bug Something isn't working label Sep 15, 2023
@rlmestre
Copy link
Contributor Author

Actually those deep imports will be removed, so maybe we change it to import 'zone.js'; now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant