From 433c50e8a018ee832872a1c7caca014d0271d358 Mon Sep 17 00:00:00 2001
From: Leblanc Meneses <leblanc@robusthaven.com>
Date: Thu, 4 Apr 2024 17:48:20 -0500
Subject: [PATCH] fix(router): support server-side-data-fetching when using a
 custom basehref (#997)

---
 .../docs/features/deployment/overview.md      | 51 +++++++++++++++++++
 packages/router/src/lib/route-config.ts       |  4 +-
 2 files changed, 54 insertions(+), 1 deletion(-)

diff --git a/apps/docs-app/docs/features/deployment/overview.md b/apps/docs-app/docs/features/deployment/overview.md
index 7c03e49e4..df10df115 100644
--- a/apps/docs-app/docs/features/deployment/overview.md
+++ b/apps/docs-app/docs/features/deployment/overview.md
@@ -48,3 +48,54 @@ export default defineConfig({
   ],
 });
 ```
+
+## Deploying with a Custom URL Prefix
+
+If you are deploying with a custom URL prefix, such as https://domain.com/`basehref`/ you must do these steps for [server-side-data-fetching](https://analogjs.org/docs/features/data-fetching/server-side-data-fetching), [html markup and assets](https://angular.io/api/common/APP_BASE_HREF), and [dynamic api routes](https://analogjs.org/docs/features/api/overview) to work correctly on the specified `basehref`.
+
+1. Instruct Angular on how recognize and generate URLs. Create a new file `app.config.env.ts`.
+
+```ts
+import { ApplicationConfig } from '@angular/core';
+import { APP_BASE_HREF } from '@angular/common';
+
+export const envConfig: ApplicationConfig = {
+  providers: [{ provide: APP_BASE_HREF, useValue: '/basehref/' }],
+};
+```
+
+2. Update the `app.config.ts` file to use the new file.
+
+```ts
+import { mergeApplicationConfig } from '@angular/core';
+import { envConfig } from './app.config.env';
+
+export const appConfig = mergeApplicationConfig(envConfig, {
+....
+});
+```
+
+3. In CI production build
+
+```bash
+  # sets the base url for server-side data fetching
+  export VITE_ANALOG_PUBLIC_BASE_URL="https://domain.com/basehref"
+  # prefixes all assets and html with /basehref/
+  npx nx run appname:build:production --baseHref='/basehref/'
+```
+
+4. In production containers specify the env flag `NITRO_APP_BASE_URL`.
+
+```bash
+NITRO_APP_BASE_URL="/basehref/"
+```
+
+Given a `vite.config.ts` file similar to this:
+
+```ts
+    plugins: [
+      analog({
+        apiPrefix: 'api',
+```
+
+Nitro prefixes all API routes with `/basehref/api`.
diff --git a/packages/router/src/lib/route-config.ts b/packages/router/src/lib/route-config.ts
index 4d3b83807..a42784ba9 100644
--- a/packages/router/src/lib/route-config.ts
+++ b/packages/router/src/lib/route-config.ts
@@ -39,7 +39,9 @@ export function toRouteConfig(routeMeta: RouteMeta | undefined): RouteConfig {
         const segment =
           parent?.url.map((segment) => segment.path).join('/') || '';
         const url = new URL('', import.meta.env['VITE_ANALOG_PUBLIC_BASE_URL']);
-        url.pathname = `/api/_analog${routeConfig[ANALOG_META_KEY].endpoint}`;
+        url.pathname = `${
+          url.pathname.endsWith('/') ? url.pathname : url.pathname + '/'
+        }api/_analog${routeConfig[ANALOG_META_KEY].endpoint}`;
         url.search = `${new URLSearchParams(queryParams).toString()}`;
         url.hash = hash ?? '';