Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow the system theme by default #87

Open
xmha97 opened this issue Feb 23, 2023 · 8 comments · May be fixed by #140
Open

Follow the system theme by default #87

xmha97 opened this issue Feb 23, 2023 · 8 comments · May be fixed by #140
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@xmha97
Copy link

xmha97 commented Feb 23, 2023

Please follow the system theme by default.

@amugofjava amugofjava added enhancement New feature or request good first issue Good for newcomers labels Feb 25, 2023
@UtkarshDeoli
Copy link

hey can i do it @amugofjava ?

@amugofjava
Copy link
Owner

Hi @UtkarshDeoli, yes if you would like to work on this please go ahead. Please let me know your thoughts on how you plan to implement this. Thanks.

@amugofjava
Copy link
Owner

Hi @UtkarshDeoli - just catching up on this issue. Have you started looking at this? Thanks.

@mrkrash
Copy link
Contributor

mrkrash commented Feb 21, 2024

Hi @amugofjava, if @UtkarshDeoli do not work anymore on this, can I?

@amugofjava
Copy link
Owner

Hi @mrkrash,

Yes, sure I'm happy for you to pick this one up. Thank you. Let's discuss this after the auto delete option is merged.

@aazmii
Copy link

aazmii commented Jan 24, 2025

@amugofjava Seems like it's not been fixed yet, can i work on this issue ?

@amugofjava
Copy link
Owner

Hi @anasmj,

This issue is still outstanding. Let's give @mrkrash a couple of days to respond, in case he has already started this, but if we do not hear from him then yes, please feel free to work on this one.

Currently, the theme is a simple toggle switch. This will need to change, perhaps to a selection box, so the user can select System, Light or Dark. I also have plans to introduce new themes which can be added to the list at a later date.

Thanks.

@mrkrash
Copy link
Contributor

mrkrash commented Jan 28, 2025

Hi @anasmj, @amugofjava,
I have already develop this feature in my repo. Today, I rebase it and if it's all ok, make a PR..

@mrkrash mrkrash linked a pull request Jan 28, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants