Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for session error and close #61

Merged
merged 1 commit into from
Jul 28, 2020

Conversation

ramya-rao-a
Copy link
Collaborator

Description

Brief description of the changes made in the PR. This helps in making better changelog

  • Add tests for session_close and session_error events based on the patterns used in connection.spec.ts file

In #34, we ensured that all listeners on a link/session are removed when the link/session is closed.
Due to this, the test for session_close was failing as the listener was being removed before session.close() completed.
So, this PR also includes

  • move the removing of listeners only after the close() operation is complete instead of doing so in the very beginning
  • tests to ensure that we have no listeners attached after the close() operation completes

Reference to any github issues

@ramya-rao-a ramya-rao-a requested a review from chradek July 28, 2020 02:53
@ramya-rao-a
Copy link
Collaborator Author

cc @richardpark-msft

Copy link
Collaborator

@chradek chradek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ramya-rao-a ramya-rao-a merged commit 86cad30 into amqp:master Jul 28, 2020
@ramya-rao-a ramya-rao-a deleted the session-tests branch July 28, 2020 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants