Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In LogIfFailed() the default logging level should be Error #151

Closed
schoetbi opened this issue Sep 27, 2022 · 2 comments
Closed

In LogIfFailed() the default logging level should be Error #151

schoetbi opened this issue Sep 27, 2022 · 2 comments

Comments

@schoetbi
Copy link

schoetbi commented Sep 27, 2022

When a result has Errors the default logging level in the various LogIfFailed methods should be LogLevel.Error. In case I want to have a warning instead, I could overwrite this. The current default value could lead to an error that will not be logged due to a mild logging level.

 public TResult LogIfFailed(string context, string content = null, LogLevel logLevel = LogLevel.Error)
        {
            if (IsFailed)
                return Log(context, content, logLevel);

            return (TResult)this;
        }
@altmann
Copy link
Owner

altmann commented Sep 28, 2022

Hi, thank you. I will have a look at it.

@altmann
Copy link
Owner

altmann commented Oct 14, 2022

The new package is out 3.14.0

Thank you for your feedback!

@altmann altmann closed this as completed Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants