-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace float64 with Float64Dtype in pandas #264
Comments
EvalML is currently adding support for pandas 1.2.0 |
EvalML now supports pandas 1.2.0: |
Blocked until Koalas fixes the 1.2.0 restriction: databricks/koalas#2137 |
One thought is that instead of changing the underlying dtype for Double, we could add a Logical Type This way we avoid causing downstream problems with the new Float64Dtype. Thoughts @freddyaboulton @thehomebrewnerd @tamargrey ? |
I thought about this a bit as well. My main hesitation is that I'm not sure the I also wonder if we should do this now or just wait a while longer until the I'm rambling a bit...which means I'm undecided and don't have a strong opinion either way... |
I think I'd vote for not having
|
Alright, let's icebox this for now and close the We can also revisit if we find a compelling use-case for it. |
The text was updated successfully, but these errors were encountered: