Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

Update entrypoint to Vega-Lite 5 so Altair v5 chart renders #52

Closed
indigoviolet opened this issue Jan 9, 2023 · 7 comments
Closed

Update entrypoint to Vega-Lite 5 so Altair v5 chart renders #52

indigoviolet opened this issue Jan 9, 2023 · 7 comments

Comments

@indigoviolet
Copy link

I recently had to update altair to master to address an unrelated issue, and found that altair_viewer's registration no longer worked. Might need to update the entrypoints to something like

https://github.com/vega/ipyvega/blob/e7fb07ce599f78117b94bcaeddd8dc56e5554a38/pyproject.toml#L40

@indigoviolet
Copy link
Author

workaround is something like alt.renderers.register('altair_viewer', altair_viewer._viewer.ChartViewer().render)

@joelostblom
Copy link
Member

Yes, there will need to be a new release of altair_viewer that matches the version of vega-lite used in the new version of altair before it works out of the box again

@mattijn mattijn changed the title Renderer registration might have changed Update entrypoint to Vega-Lite 5 for so Altair v5 chart renders Feb 1, 2023
@mattijn
Copy link
Member

mattijn commented Feb 1, 2023

@indigoviolet I have one question. You mention you found a workaround. Can you provide a small complete code snippet how you apply this? I'm wondering how that could work.

@mattijn mattijn changed the title Update entrypoint to Vega-Lite 5 for so Altair v5 chart renders Update entrypoint to Vega-Lite 5 so Altair v5 chart renders Feb 1, 2023
@joelostblom
Copy link
Member

I think we can close this as #54 was merged. There will be one more update when VL 5.7 is out and after that a new release of altair_viewer will be out.

@mattijn
Copy link
Member

mattijn commented Mar 22, 2023

I think this can't be closed. It still requires a new entry point for Altair vl 5, around here:

https://github.com/altair-viz/altair_viewer/blob/master/setup.py#L74

@mattijn mattijn reopened this Mar 22, 2023
@mattijn
Copy link
Member

mattijn commented Apr 16, 2023

done per #55

@mattijn mattijn closed this as completed Apr 16, 2023
@franzhaas
Copy link

This now affects the released version of altair 5.0.1 as well as 5.0.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants