Data.Set for class parents

For O(log n) append.
The analysis worklist is more times appended to, so we also make it a
Set.

Author: alt-romes

src/Data/Equality/Graph.hs

@@ -38,8 +38,6 @@ import Data.Function
 import Data.Bifunctor
 import Data.Containers.ListUtils
 
-import Data.Sequence (Seq(..))
-import qualified Data.Sequence as Seq
 import qualified Data.Foldable as F
 import qualified Data.IntMap.Strict as IM
 import qualified Data.Set    as S
@@ -85,7 +83,7 @@ add uncanon_e egr =
             -- to the e-class parents the new e-node and its e-class id
             --
             -- And add new e-class to existing e-classes
-            new_parents      = ((new_eclass_id, new_en) :<|)
+            new_parents      = (S.insert (new_eclass_id, new_en))
             new_classes      = IM.insert new_eclass_id new_eclass $
                                     foldr  (IM.adjust ((_parents %~ new_parents)))
                                            (classes egr)
@@ -154,7 +152,7 @@ merge a b egr0 =
 
            -- Leader is the class with more parents
            (leader, leader_class, sub, sub_class) =
-               if Seq.length (class_a^._parents) < Seq.length (class_b^._parents)
+               if S.size (class_a^._parents) < S.size (class_b^._parents)
                   then (b', class_b, a', class_a) -- b is leader
                   else (a', class_a, b', class_b) -- a is leader
 
@@ -181,7 +179,7 @@ merge a b egr0 =
            -- class whose data is different from the merged must be put on the
            -- analysisWorklist
            new_analysis_worklist =
-             F.toList (
+             (
                (if new_data /= (sub_class^._data)
                    then sub_class^._parents
                    else mempty) <>
@@ -222,7 +220,7 @@ rebuild (EGraph uf cls mm wl awl) =
   let
     emptiedEgr = EGraph uf cls mm mempty mempty
     wl'   = nubOrd $ bimap (`find` emptiedEgr) (`canonicalize` emptiedEgr) <$> wl
-    awl'  = nubOrd $ bimap (`find` emptiedEgr) (`canonicalize` emptiedEgr) <$> awl
+    awl'  = S.map (bimap (`find` emptiedEgr) (`canonicalize` emptiedEgr)) awl
     egr'  = foldr repair emptiedEgr wl'
     egr'' = foldr repairAnal egr'   awl'
   in
@@ -258,7 +256,7 @@ repairAnal (repair_id, node) egr =
     if c^._data /= new_data
         -- Merge result is different from original class data, update class
         -- with new_data
-       then egr { analysisWorklist = F.toList (c^._parents) <> analysisWorklist egr
+       then egr { analysisWorklist = (c^._parents) <> analysisWorklist egr
                 }
                 & _class repair_id._data .~ new_data
                 & modifyA repair_id

src/Data/Equality/Graph/Classes.hs

@@ -8,7 +8,6 @@ module Data.Equality.Graph.Classes
     , module Data.Equality.Graph.Classes.Id
     ) where
 
-import qualified Data.Sequence  as Seq
 import qualified Data.Set as S
 
 import Data.Functor.Classes
@@ -28,7 +27,7 @@ data EClass l = EClass
     { eClassId      :: {-# UNPACK #-} !ClassId -- ^ E-class identifier
     , eClassNodes   :: !(S.Set (ENode l))      -- ^ E-nodes in this class
     , eClassData    :: Domain l                -- ^ The analysis data associated with this eclass.
-    , eClassParents :: !(Seq.Seq (ClassId, ENode l))   -- ^ E-nodes which are parents of this e-class and their corresponding e-class ids.
+    , eClassParents :: !(S.Set (ClassId, ENode l))   -- ^ E-nodes which are parents of this e-class and their corresponding e-class ids.
     }
 
 instance (Show (Domain l), Show1 l) => Show (EClass l) where

src/Data/Equality/Graph/Internal.hs

@@ -7,6 +7,7 @@
 module Data.Equality.Graph.Internal where
 
 import Data.Functor.Classes
+import qualified Data.Set as S
 
 import Data.Equality.Graph.ReprUnionFind
 import Data.Equality.Graph.Classes
@@ -23,7 +24,7 @@ data EGraph l = EGraph
     , classes   :: !(ClassIdMap (EClass l)) -- ^ Map canonical e-class ids to their e-classes
     , memo      :: !(Memo l)                -- ^ Hashcons maps all canonical e-nodes to their e-class ids
     , worklist  :: !(Worklist l)            -- ^ Worklist of e-class ids that need to be upward merged
-    , analysisWorklist :: !(Worklist l)     -- ^ Like 'worklist' but for analysis repairing
+    , analysisWorklist :: !(S.Set (ClassId, ENode l))     -- ^ Like 'worklist' but for analysis repairing
     }
 
 -- | The hashcons 𝐻  is a map from e-nodes to e-class ids

src/Data/Equality/Graph/Lens.hs

@@ -8,7 +8,6 @@
  -}
 module Data.Equality.Graph.Lens where
 
-import qualified Data.Sequence  as Seq
 import qualified Data.IntMap.Strict as IM
 import qualified Data.Set as S
 
@@ -62,7 +61,7 @@ _data afa EClass{..} = (\d1 -> EClass eClassId eClassNodes d1 eClassParents) <$>
 {-# INLINE _data #-}
 
 -- | Lens for the parent e-classes of an e-class
-_parents :: Lens' (EClass l) (Seq.Seq (ClassId, ENode l))
+_parents :: Lens' (EClass l) (S.Set (ClassId, ENode l))
 _parents afa EClass{..} = (\ps -> EClass eClassId eClassNodes eClassData ps) <$> afa eClassParents
 {-# INLINE _parents #-}