From d0d116968e4653fbe973006e38331ed2de29ca0e Mon Sep 17 00:00:00 2001 From: Toby Lorne Date: Tue, 23 Jun 2020 13:36:57 +0100 Subject: [PATCH] prs: update pending step in separate context from the docs: --- When specifying skip_download the pull request volume mounted to subsequent tasks will be empty, which is a problem when you set e.g. the pending status before running the actual tests. The workaround for this is to use an alias for the put (see https://github.com/telia-oss/github-pr-resource/issues/32 for more details). Example here: put: update-status <-- Use an alias for the pull-request resource resource: pull-request params: path: pull-request status: pending get_params: {skip_download: true} --- Signed-off-by: Toby Lorne --- pipelines/build-release.yml | 3 +- .../build-docker-pull-requests.yml | 51 ++++++++++++------- 2 files changed, 36 insertions(+), 18 deletions(-) diff --git a/pipelines/build-release.yml b/pipelines/build-release.yml index ca4a4c3..fb8b7de 100644 --- a/pipelines/build-release.yml +++ b/pipelines/build-release.yml @@ -73,7 +73,8 @@ jobs: trigger: true params: integration_tool: checkout - - put: bosh-release-pr + - put: update-bosh-release-pr + resource: bosh-release-pr params: path: bosh-release-pr context: ((github_status_context)) diff --git a/pipelines/plain_pipelines/build-docker-pull-requests.yml b/pipelines/plain_pipelines/build-docker-pull-requests.yml index 7c7403d..b835b99 100644 --- a/pipelines/plain_pipelines/build-docker-pull-requests.yml +++ b/pipelines/plain_pipelines/build-docker-pull-requests.yml @@ -144,7 +144,8 @@ jobs: trigger: true params: integration_tool: checkout - - put: paas-docker-cloudfoundry-tools-pr + - put: update-paas-docker-cloudfoundry-tools-pr + resource: paas-docker-cloudfoundry-tools-pr params: path: paas-docker-cloudfoundry-tools-pr context: ((github_status_context)) @@ -219,7 +220,8 @@ jobs: trigger: true params: integration_tool: checkout - - put: paas-docker-cloudfoundry-tools-pr + - put: update-paas-docker-cloudfoundry-tools-pr + resource: paas-docker-cloudfoundry-tools-pr params: path: paas-docker-cloudfoundry-tools-pr context: ((github_status_context)) @@ -264,7 +266,8 @@ jobs: trigger: true params: integration_tool: checkout - - put: paas-docker-cloudfoundry-tools-pr + - put: update-paas-docker-cloudfoundry-tools-pr + resource: paas-docker-cloudfoundry-tools-pr params: path: paas-docker-cloudfoundry-tools-pr context: ((github_status_context)) @@ -309,7 +312,8 @@ jobs: trigger: true params: integration_tool: checkout - - put: paas-docker-cloudfoundry-tools-pr + - put: update-paas-docker-cloudfoundry-tools-pr + resource: paas-docker-cloudfoundry-tools-pr params: path: paas-docker-cloudfoundry-tools-pr context: ((github_status_context)) @@ -354,7 +358,8 @@ jobs: trigger: true params: integration_tool: checkout - - put: paas-docker-cloudfoundry-tools-pr + - put: update-paas-docker-cloudfoundry-tools-pr + resource: paas-docker-cloudfoundry-tools-pr params: path: paas-docker-cloudfoundry-tools-pr context: ((github_status_context)) @@ -399,7 +404,8 @@ jobs: trigger: true params: integration_tool: checkout - - put: paas-docker-cloudfoundry-tools-pr + - put: update-paas-docker-cloudfoundry-tools-pr + resource: paas-docker-cloudfoundry-tools-pr params: path: paas-docker-cloudfoundry-tools-pr context: ((github_status_context)) @@ -444,7 +450,8 @@ jobs: trigger: true params: integration_tool: checkout - - put: paas-docker-cloudfoundry-tools-pr + - put: update-paas-docker-cloudfoundry-tools-pr + resource: paas-docker-cloudfoundry-tools-pr params: path: paas-docker-cloudfoundry-tools-pr context: ((github_status_context)) @@ -489,7 +496,8 @@ jobs: trigger: true params: integration_tool: checkout - - put: paas-docker-cloudfoundry-tools-pr + - put: update-paas-docker-cloudfoundry-tools-pr + resource: paas-docker-cloudfoundry-tools-pr params: path: paas-docker-cloudfoundry-tools-pr context: ((github_status_context)) @@ -534,7 +542,8 @@ jobs: trigger: true params: integration_tool: checkout - - put: paas-docker-cloudfoundry-tools-pr + - put: update-paas-docker-cloudfoundry-tools-pr + resource: paas-docker-cloudfoundry-tools-pr params: path: paas-docker-cloudfoundry-tools-pr context: ((github_status_context)) @@ -579,7 +588,8 @@ jobs: trigger: true params: integration_tool: checkout - - put: paas-docker-cloudfoundry-tools-pr + - put: update-paas-docker-cloudfoundry-tools-pr + resource: paas-docker-cloudfoundry-tools-pr params: path: paas-docker-cloudfoundry-tools-pr context: ((github_status_context)) @@ -624,7 +634,8 @@ jobs: trigger: true params: integration_tool: checkout - - put: paas-docker-cloudfoundry-tools-pr + - put: update-paas-docker-cloudfoundry-tools-pr + resource: paas-docker-cloudfoundry-tools-pr params: path: paas-docker-cloudfoundry-tools-pr context: ((github_status_context)) @@ -669,7 +680,8 @@ jobs: trigger: true params: integration_tool: checkout - - put: paas-docker-cloudfoundry-tools-pr + - put: update-paas-docker-cloudfoundry-tools-pr + resource: paas-docker-cloudfoundry-tools-pr params: path: paas-docker-cloudfoundry-tools-pr context: ((github_status_context)) @@ -714,7 +726,8 @@ jobs: trigger: true params: integration_tool: checkout - - put: paas-docker-cloudfoundry-tools-pr + - put: update-paas-docker-cloudfoundry-tools-pr + resource: paas-docker-cloudfoundry-tools-pr params: path: paas-docker-cloudfoundry-tools-pr context: ((github_status_context)) @@ -759,7 +772,8 @@ jobs: trigger: true params: integration_tool: checkout - - put: paas-docker-cloudfoundry-tools-pr + - put: update-paas-docker-cloudfoundry-tools-pr + resource: paas-docker-cloudfoundry-tools-pr params: path: paas-docker-cloudfoundry-tools-pr context: ((github_status_context)) @@ -804,7 +818,8 @@ jobs: trigger: true params: integration_tool: checkout - - put: paas-docker-cloudfoundry-tools-pr + - put: update-paas-docker-cloudfoundry-tools-pr + resource: paas-docker-cloudfoundry-tools-pr params: path: paas-docker-cloudfoundry-tools-pr context: ((github_status_context)) @@ -849,7 +864,8 @@ jobs: trigger: true params: integration_tool: checkout - - put: paas-tech-docs-pr + - put: update-paas-tech-docs-pr + resource: paas-tech-docs-pr params: path: paas-tech-docs-pr context: ((github_status_context)) @@ -921,7 +937,8 @@ jobs: trigger: true params: integration_tool: checkout - - put: paas-semver-resource-pr + - put: update-paas-semver-resource-pr + resource: paas-semver-resource-pr params: path: paas-semver-resource-pr context: ((github_status_context))