From 33f18fa4385186323555d28afb623e4a6c454fd2 Mon Sep 17 00:00:00 2001 From: AshGDS <8880610+AshGDS@users.noreply.github.com> Date: Mon, 11 Nov 2024 11:36:32 +0000 Subject: [PATCH] Add component wrapper helper to the header --- CHANGELOG.md | 1 + .../components/_layout_header.html.erb | 14 +++++++++----- .../components/docs/layout_header.yml | 1 + 3 files changed, 11 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1397cd4044..e0959620f3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,7 @@ ## Unreleased * Enhance Youtube without cookies ([PR #4388](https://github.com/alphagov/govuk_publishing_components/pull/4388)) +* Add component wrapper helper to the header ([PR #4385](https://github.com/alphagov/govuk_publishing_components/pull/4385)) * Add component wrapper helper to the footer ([PR #4380](https://github.com/alphagov/govuk_publishing_components/pull/4380)) * Add component wrapper to the inset text component ([PR #4387](https://github.com/alphagov/govuk_publishing_components/pull/4387)) * Rename gem-print-link and gem-print-links-within ([PR #4375](https://github.com/alphagov/govuk_publishing_components/pull/4375)) diff --git a/app/views/govuk_publishing_components/components/_layout_header.html.erb b/app/views/govuk_publishing_components/components/_layout_header.html.erb index ea875901f5..28b3d0a16e 100644 --- a/app/views/govuk_publishing_components/components/_layout_header.html.erb +++ b/app/views/govuk_publishing_components/components/_layout_header.html.erb @@ -11,12 +11,16 @@ width_class = full_width ? "govuk-header__container--full-width" : "govuk-width-container" logo_link ||= "/" - header_classes = %w[gem-c-layout-header govuk-header] - header_classes << "gem-c-layout-header--#{environment}" if environment - header_classes << "gem-c-layout-header--no-bottom-border" if remove_bottom_border + component_helper = GovukPublishingComponents::Presenters::ComponentWrapperHelper.new(local_assigns) + component_helper.add_class("gem-c-layout-header govuk-header") + component_helper.add_class("gem-c-layout-header--#{environment}") if environment + component_helper.add_class("gem-c-layout-header--no-bottom-border") if remove_bottom_border + component_helper.add_role("banner") + component_helper.add_data_attribute({ module: "govuk-header" }) + %> - +<% end %> diff --git a/app/views/govuk_publishing_components/components/docs/layout_header.yml b/app/views/govuk_publishing_components/components/docs/layout_header.yml index 1719c2c20e..74cc605259 100644 --- a/app/views/govuk_publishing_components/components/docs/layout_header.yml +++ b/app/views/govuk_publishing_components/components/docs/layout_header.yml @@ -5,6 +5,7 @@ body: | staging or production). govuk_frontend_components: - header +uses_component_wrapper_helper: true accessibility_excluded_rules: - landmark-banner-is-top-level # The header element can not be top level in the examples - duplicate-id # IDs will be duplicated in component examples list