Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally revealing content with checkboxes not announcing collapsed/expanded state on macOS with VoiceOver #575

Closed
selfthinker opened this issue Nov 10, 2017 · 1 comment

Comments

@selfthinker
Copy link
Contributor

When using the conditionally revealing content component VoiceOver on macOS in Safari doesn't announce that it is collapsed or expanded, despite the use of aria-expanded and others. All other screen readers are fine with it. Weirdly, that only happens when using checkboxes, not radio buttons!

How would you expect it to work?

When on the trigger ("Citizen of a different country"), VoiceOver should say "collapsed" (like it does when using the same component with radio buttons). When triggering it, it should say "expanded".

How does it work currently?

It doesn't say whether it's collapsed or expanded.

Feel free to suggest a fix...

I tried a few things (removing aria-hidden, removing aria-controls and moving aria-expanded) but nothing I tried fixed it. It's probably a bug in VoiceOver and/or Safari, but I wasn't able to make a reduced test case, so haven't reported it.

I was wondering if this bug has anything to do with #455 (or alphagov/govuk_frontend_toolkit#419), but the invalid ARIA attribute that issue is talking about is only invalid for radio buttons, not checkboxes. And #573 is thematically related but otherwise probably not at all.

It's very unlikely that this bug will create a barrier as tabbing or down-arrowing or moving to the next form field would always go to the just revealed form field. As such, fixing this has a low priority.

@NickColley
Copy link
Contributor

Following the launch of the GOV.UK Design System, GOV.UK Elements will now only get major bug fixes and security patches.

This is definitely still an issue, and we will investigate this and see if we can resolve it in GOV.UK Frontend: alphagov/govuk-frontend#989

Thanks so much for these great issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants