Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not enough vertical spacing on check your answers sections #541

Closed
daviddotto opened this issue Jul 9, 2018 · 8 comments
Closed

Not enough vertical spacing on check your answers sections #541

daviddotto opened this issue Jul 9, 2018 · 8 comments
Labels
🐛 Bug Something isn't working the way it should (including incorrect wording in documentation)
Milestone

Comments

@daviddotto
Copy link
Contributor

https://govuk-prototype-kit.herokuapp.com/docs/examples/check-your-answers-page

In example page, sections are spaced too closely together, making distinguishing sections difficult.

Additional margin could be added to the bottom of .app-check-your-answers sections to add white space.

@NickColley
Copy link
Contributor

NickColley commented Jul 9, 2018

Whitespace at GOV.UK Frontend 6.x

Whitespace at GOV.UK Frontend 6.x

Whitespace at GOV.UK Frontend 7.x

Whitespace at GOV.UK Frontend 7.x

@NickColley NickColley added this to the 7.0.0 (Stable) milestone Jul 9, 2018
@kr8n3r
Copy link

kr8n3r commented Jul 9, 2018

can't immediately see any obvious padding change 32e20ec#diff-a43f72cb22732f4fb3b3457903970c99

@dashouse
Copy link

dashouse commented Jul 9, 2018

Looks like there’s a couple of issues with that example, because we don’t have a

defined in Frontend it is using HTML defaults.

Rather than adding your own padding I would suggest using the responsive spacing scale –

Try this on each

<dl class="govuk-!-margin-bottom-0 govuk-!-margin-bottom-9 app-check-your-answers app-check-your-answers--short">

@daviddotto
Copy link
Contributor Author

I'm currently adding govuk-!-padding-top-5 to the h2 heading above each section, this has replicated the styling of the old prototype kit, It looks like the changes to heading padding has caused everything to look very compressed on that page

@dashouse
Copy link

dashouse commented Jul 9, 2018

Hey David, that's great. When we make this change to the kit we'll be zeroing out the margin-top of the <dl> and only adding margin-bottom unless necessary to bring it in line with out components and typography. We are generally trying to only apply spacing in one direction, but it's absolutely fine to do this within your own app.

@daviddotto
Copy link
Contributor Author

Makes a lot of sense, it did seem a little hacky when I was putting it in, the only issue I had with it was it didn't solve the issue of the first h2 section header being too close to the top heading

@NickColley NickColley added the 🐛 Bug Something isn't working the way it should (including incorrect wording in documentation) label Jul 10, 2018
@kr8n3r
Copy link

kr8n3r commented Jul 12, 2018

being fixed here: #547

@NickColley
Copy link
Contributor

This will be fixed in the next release, thanks for raising :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working the way it should (including incorrect wording in documentation)
Projects
None yet
Development

No branches or pull requests

4 participants