From f81b1920cb9aae655ed2f129cc018a783857135e Mon Sep 17 00:00:00 2001 From: Nick Colley Date: Thu, 6 Sep 2018 16:38:07 +0100 Subject: [PATCH 1/2] Remove anchor styling in govuk-lists This need can be satisfied by enabling global styles, which is on by default in the GOV.UK Prototype Kit. I have checked our [documentation](https://design-system.service.gov.uk/styles/typography/#lists) and we do not recommend our users do this. With this both in mind this feels reasonable to remove this functionality as a breaking change. --- src/core/_lists.scss | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/src/core/_lists.scss b/src/core/_lists.scss index 3cd3c24ff9..ed3e708ae7 100644 --- a/src/core/_lists.scss +++ b/src/core/_lists.scss @@ -20,24 +20,6 @@ } } - %govuk-list a { - &:link { - color: $govuk-link-colour; - } - - &:visited { - color: $govuk-link-visited-colour; - } - - &:hover { - color: $govuk-link-hover-colour; - } - - &:active { - color: $govuk-link-active-colour; - } - } - .govuk-list { @extend %govuk-list; } From 6adca30e605e62cc6d57cf1ca099b057b67884b9 Mon Sep 17 00:00:00 2001 From: Nick Colley Date: Thu, 6 Sep 2018 16:45:28 +0100 Subject: [PATCH 2/2] Update CHANGELOG --- CHANGELOG.md | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 498be00f85..9258054f6a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -103,6 +103,16 @@ ``` ([PR #981](https://github.com/alphagov/govuk-frontend/pull/981)) +- Remove anchor styling in govuk-lists + + This was an undocumented feature of lists. + + To migrate we recommend using adding `.govuk-link` class to any anchors within a govuk-list. + + If you would like to replicate this functionality without adding a class you can also enable [global styles](https://github.com/alphagov/govuk-frontend/blob/master/docs/installation/installing-with-npm.md#global-styles) (Note: global styles are enabled by default in the GOV.UK Prototype Kit) + + ([PR #985](https://github.com/alphagov/govuk-frontend/pull/985)) + - Pull Request Title goes here Description goes here (optional)