From 7847bddceeecab95aa9b8fc2bb3af04f6c226763 Mon Sep 17 00:00:00 2001 From: Dave House Date: Thu, 12 Jul 2018 09:57:04 +0100 Subject: [PATCH 1/3] Adjust internal padding of tab content and margin on mobile breakpoint --- src/components/tabs/_tabs.scss | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/components/tabs/_tabs.scss b/src/components/tabs/_tabs.scss index c97bb9fb07..0e74c3073a 100644 --- a/src/components/tabs/_tabs.scss +++ b/src/components/tabs/_tabs.scss @@ -21,7 +21,7 @@ padding: 0; list-style: none; @include mq($until: tablet) { - @include govuk-responsive-margin(2, "bottom"); + @include govuk-responsive-margin(6, "bottom"); } } @@ -50,6 +50,10 @@ } } + .govuk-tabs__panel { + @include govuk-responsive-margin(8, "bottom"); + } + // JavaScript enabled .js-enabled { @@ -104,9 +108,10 @@ } .govuk-tabs__panel { + @include govuk-responsive-margin(0, "bottom"); padding-top: govuk-spacing(6); padding-right: govuk-spacing(4); - padding-bottom: govuk-spacing(2); + padding-bottom: govuk-spacing(6); padding-left: govuk-spacing(4); border: 1px solid $govuk-border-colour; border-top: 0; From 2d8809553acb23a21c58b61b5c290f47368ac4f7 Mon Sep 17 00:00:00 2001 From: Dave House Date: Thu, 12 Jul 2018 10:53:11 +0100 Subject: [PATCH 2/3] Use :last-child to remove the margin of the last item in the tab content --- src/components/tabs/_tabs.scss | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/components/tabs/_tabs.scss b/src/components/tabs/_tabs.scss index 0e74c3073a..9d8d9de7c1 100644 --- a/src/components/tabs/_tabs.scss +++ b/src/components/tabs/_tabs.scss @@ -115,6 +115,10 @@ padding-left: govuk-spacing(4); border: 1px solid $govuk-border-colour; border-top: 0; + + & > :last-child { + margin-bottom: 0; + } } } From e2523fc39affd421ed31d97d6c349e09e7d292b2 Mon Sep 17 00:00:00 2001 From: Nick Colley Date: Mon, 16 Jul 2018 10:45:05 +0100 Subject: [PATCH 3/3] Update CHANGELOG for tabs spacing changes --- CHANGELOG.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7cf3bcb478..fd5cdeea05 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -23,9 +23,11 @@ 🔧 Fixes: - Update details behaviour to remove margin-bottom for all elements - ([PR #900](https://github.com/alphagov/govuk-frontend/pull/900)) +- Update internal padding of tab content in the tabs component + ([PR #886](https://github.com/alphagov/govuk-frontend/pull/886)) + ## 1.1.0 (feature release) 🆕 New features: