From 8a2634c60c5f3058b0f3a5f3fd6b99fa4e20b8fb Mon Sep 17 00:00:00 2001 From: Oliver Byford Date: Thu, 12 Apr 2018 12:01:58 +0100 Subject: [PATCH 1/2] Remove redundant font-family rule in button Remove explicit font-family definition from the button scss. We don't need it because we get it as part of the included `govuk-font-regular` mixin which defines the font for us. This will remove a redundant duplicated font-family rule and also mean that the button will correctly fall back to the print font when printed. --- src/button/_button.scss | 1 - 1 file changed, 1 deletion(-) diff --git a/src/button/_button.scss b/src/button/_button.scss index 8026afdf48..f03dc0bcb5 100644 --- a/src/button/_button.scss +++ b/src/button/_button.scss @@ -48,7 +48,6 @@ color: $govuk-button-text-colour; background-color: $govuk-button-colour; box-shadow: 0 $button-shadow-size 0 $govuk-button-shadow-colour; // s0 - font-family: $govuk-font-stack; text-align: center; vertical-align: top; cursor: pointer; From 3be134461aef769fb1823e5d33165182e27ca88c Mon Sep 17 00:00:00 2001 From: Oliver Byford Date: Thu, 12 Apr 2018 16:44:19 +0100 Subject: [PATCH 2/2] Add removal of font-face from button to changelog --- CHANGELOG.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 984c02c213..e739084f0b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,14 @@ Note: We're not following semantic versioning yet, we are going to talk about th ## Unreleased +Fixes: + +- Remove redundant font-family declaration from the button component – this will + also fix an issue where the button uses New Transport when printed instead of + falling back to the print stack as expected. + (PR [#650](https://github.com/alphagov/govuk-frontend/pull/650)) + + Internal - Update publishing docs (PR [#651](https://github.com/alphagov/govuk-frontend/pull/651))