From 8fbc5626786a03d1ee9bd2924b0ca7bb68f87683 Mon Sep 17 00:00:00 2001 From: Frankie Roberto Date: Wed, 30 Jan 2019 17:11:03 +0000 Subject: [PATCH 1/2] Trigger setAttributes on all radio inputs This enables the conditional reveals to work where two different macros are used with the same name attribute (eg to enable grouping of radio inputs). --- src/components/radios/radios.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/components/radios/radios.js b/src/components/radios/radios.js index 482fa6a753..0c8770c6ac 100644 --- a/src/components/radios/radios.js +++ b/src/components/radios/radios.js @@ -45,7 +45,10 @@ Radios.prototype.setAttributes = function ($input) { } Radios.prototype.handleClick = function (event) { - nodeListForEach(this.$inputs, function ($input) { + + var allRadioInputs = document.querySelectorAll('input[type="radio"]') + + nodeListForEach(allRadioInputs, function ($input) { // If a radio with aria-controls, handle click var isRadio = $input.getAttribute('type') === 'radio' var hasAriaControls = $input.getAttribute('aria-controls') From 4f384ba7e3414c7b9f2a88194c14a05c01648809 Mon Sep 17 00:00:00 2001 From: Frankie Roberto Date: Wed, 6 Feb 2019 08:43:55 +0000 Subject: [PATCH 2/2] Style fix --- src/components/radios/radios.js | 1 - 1 file changed, 1 deletion(-) diff --git a/src/components/radios/radios.js b/src/components/radios/radios.js index 0c8770c6ac..37822f65df 100644 --- a/src/components/radios/radios.js +++ b/src/components/radios/radios.js @@ -45,7 +45,6 @@ Radios.prototype.setAttributes = function ($input) { } Radios.prototype.handleClick = function (event) { - var allRadioInputs = document.querySelectorAll('input[type="radio"]') nodeListForEach(allRadioInputs, function ($input) {