Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor NotificationBanner to extend from a GOVUKFrontendConfigurableComponent class #5461

Closed
1 task
Tracked by #5373
romaricpascal opened this issue Nov 4, 2024 · 0 comments · Fixed by #5485
Closed
1 task
Tracked by #5373

Refactor NotificationBanner to extend from a GOVUKFrontendConfigurableComponent class #5461

romaricpascal opened this issue Nov 4, 2024 · 0 comments · Fixed by #5485

Comments

@romaricpascal
Copy link
Member

romaricpascal commented Nov 4, 2024 •
edited
Loading

What

Use the class created in #5456 to replace how the NotificationBanner component gathers and merge its configuration.

Why

So components share the same way to gather and merge their configuration

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

  • The NotificationBanner component uses the GOVUKFrontendConfigurableComponent class
@romaricpascal romaricpascal mentioned this issue Nov 4, 2024
Closed
@romaricpascal romaricpascal changed the title Refactor NotificationBanner to use a getConfiguration helper to compute its configuration Refactor NotificationBanner to use a getComponentConfiguration helper to compute its configuration Nov 4, 2024
@romaricpascal romaricpascal changed the title Refactor NotificationBanner to use a getComponentConfiguration helper to compute its configuration Refactor NotificationBanner to extend from a GOVUKFrontendConfigurableComponent class Nov 7, 2024
@romaricpascal romaricpascal moved this to Backlog 🏃🏼‍♀️ in GOV.UK Design System cycle board Nov 7, 2024
Merged
@patrickpatrickpatrick patrickpatrickpatrick linked a pull request Nov 11, 2024 that will close this issue
Add config helpers to components #5485
Merged
@domoscargin domoscargin moved this from Backlog 🏃🏼‍♀️ to Needs review 🔍 in GOV.UK Design System cycle board Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
GOV.UK Design System cycle board
Status: Needs review 🔍
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add config helpers to components alphagov/govuk-frontend
1 participant
@romaricpascal