Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider a default value for warningText component's iconFallbackText #2693

Closed
joelanman opened this issue Jul 14, 2022 · 0 comments · Fixed by #3312
Closed

Consider a default value for warningText component's iconFallbackText #2693

joelanman opened this issue Jul 14, 2022 · 0 comments · Fixed by #3312
Assignees
@owenatgov
Labels
feature request User requests a new feature 🕔 hours A well understood issue which we expect to take less than a day to resolve.
Milestone
v4.6.0

Comments

@joelanman
Copy link
Contributor

Related component

https://design-system.service.gov.uk/components/warning-text/

iconFallbackText is required - but 'Warning' might be a good default value, GOV.UK Publishing Components defaults to 'Warning'

Context

Reading through the options for components for the Component Editor firebreak idea.
@joelanman joelanman added feature request User requests a new feature awaiting triage Needs triaging by team labels Jul 14, 2022
@owenatgov owenatgov added 🕔 hours A well understood issue which we expect to take less than a day to resolve. and removed awaiting triage Needs triaging by team labels Feb 16, 2023
@owenatgov owenatgov added this to the [NEXT] milestone Feb 20, 2023
@owenatgov owenatgov moved this to Sprint Backlog 🏃🏼‍♀️ in GOV.UK Design System cycle board Feb 20, 2023
@owenatgov owenatgov moved this from Sprint Backlog 🏃🏼‍♀️ to In progress 📝 in GOV.UK Design System cycle board Feb 20, 2023
@owenatgov owenatgov mentioned this issue Feb 20, 2023
Merged
@owenatgov owenatgov self-assigned this Feb 20, 2023
@owenatgov owenatgov moved this from In progress 📝 to Needs review 🔍 in GOV.UK Design System cycle board Feb 20, 2023
@owenatgov owenatgov moved this from Needs review 🔍 to Ready to release 🚀 in GOV.UK Design System cycle board Feb 21, 2023
@querkmachine querkmachine moved this from Ready to release 🚀 to Done 🏁 in GOV.UK Design System cycle board Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@owenatgov owenatgov

Labels
feature request User requests a new feature 🕔 hours A well understood issue which we expect to take less than a day to resolve.
Projects
GOV.UK Design System cycle board
Archived in project
Milestone
v4.6.0
Development

Successfully merging a pull request may close this issue.

Add default value for warning text icon fallback attribute alphagov/govuk-frontend
2 participants
@joelanman @owenatgov