Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples and tests for translating error message and summary list content #2690

Closed
4 tasks done
Tracked by #1708
vanitabarrett opened this issue Jul 14, 2022 · 0 comments · Fixed by #2735
Closed
4 tasks done
Tracked by #1708

Add examples and tests for translating error message and summary list content #2690

vanitabarrett opened this issue Jul 14, 2022 · 0 comments · Fixed by #2735

Comments

@vanitabarrett
Copy link
Contributor

vanitabarrett commented Jul 14, 2022

The error message and summary list have hardcoded content order with visually hidden text which makes them difficult to translate. For our MVP internationalisation implementation, we're going to recommend users set this visually hidden text to false and then pass their own translations through the html macro option (this is already possible with the current macro options).

We should make sure we have some examples and tests for this in our review app, so we can make sure we don't unintentionally break this when making any future changes to the components.

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

  • Error message component has an example of translating the visually hidden text in the review app
  • Error message component has a test for translating the visually hidden text
  • Summary list component has an example of translating the visually hidden text in the review app
  • Summary list component has a test for translating the visually hidden text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

1 participant