Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link hover states look blocky on Safari (and Firefox) #2250

Closed
christopherthomasdesign opened this issue Jun 10, 2021 · 0 comments · Fixed by #2251
Closed

Link hover states look blocky on Safari (and Firefox) #2250

christopherthomasdesign opened this issue Jun 10, 2021 · 0 comments · Fixed by #2251
Assignees
Milestone

Comments

@christopherthomasdesign
Copy link
Member

What

The thick underlines we use in the new hover states are rendered differently by different browsers.

Chrome
Screenshot 2021-06-02 at 17 05 26

Safari
Screenshot 2021-06-02 at 17 04 17

Firefox
Screenshot 2021-06-10 at 13 57 20

I think we want it to be more like how Chrome currently does it, even if that means cutting through descenders sometimes. The examples above show how messy it can look if you have a word with lots of descenders.

It looks like text-decoration-skip-ink isn't too well supported, so we may want to look at a few different ways to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

2 participants