Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't pass classes to first item in row if first cell is header #1261

Closed
edwardhorsford opened this issue Mar 28, 2019 · 0 comments
Closed

Can't pass classes to first item in row if first cell is header #1261

edwardhorsford opened this issue Mar 28, 2019 · 0 comments
Assignees
@36degrees
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation) 🕔 hours A well understood issue which we expect to take less than a day to resolve.

Comments

@edwardhorsford
Copy link
Contributor

If the firstCellIsHeader perimeter is true, classes on that row item aren't passed to the element.

I think it just needs {%- if cell.classes %} {{ cell.classes }}{% endif %} added to the th to get it to work?
@hannalaakso hannalaakso added the awaiting triage Needs triaging by team label Mar 29, 2019
@kellylee-gds kellylee-gds added 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) 🕔 hours A well understood issue which we expect to take less than a day to resolve. Priority: low and removed awaiting triage Needs triaging by team labels Apr 10, 2019
@36degrees 36degrees self-assigned this May 15, 2019
@36degrees 36degrees mentioned this issue May 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@36degrees 36degrees

Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation) 🕔 hours A well understood issue which we expect to take less than a day to resolve.
Projects
GOV.UK Design System cycle board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@36degrees @edwardhorsford @hannalaakso @kellylee-gds