From 0304ec9890d6803803bf0b788a47a49173a88f4d Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 28 Nov 2022 16:50:07 +0000 Subject: [PATCH 1/2] Bump axe-puppeteer from 1.0.0 to 1.1.1 Bumps [axe-puppeteer](https://github.com/dequelabs/axe-puppeteer) from 1.0.0 to 1.1.1. - [Release notes](https://github.com/dequelabs/axe-puppeteer/releases) - [Changelog](https://github.com/dequelabs/axe-puppeteer/blob/develop/CHANGELOG.md) - [Commits](https://github.com/dequelabs/axe-puppeteer/commits) --- updated-dependencies: - dependency-name: axe-puppeteer dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- package-lock.json | 18 ++++++++++-------- package.json | 2 +- 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/package-lock.json b/package-lock.json index 9da8422a65..cf0e678528 100644 --- a/package-lock.json +++ b/package-lock.json @@ -28,7 +28,7 @@ "@metalsmith/permalinks": "^2.4.1", "@metalsmith/sass": "^1.2.0", "accessible-autocomplete": "^2.0.4", - "axe-puppeteer": "^1.0.0", + "axe-puppeteer": "^1.1.1", "fs-extra": "^10.1.0", "iframe-resizer": "^3.6.6", "jest": "^29.3.1", @@ -2871,26 +2871,28 @@ } }, "node_modules/axe-core": { - "version": "3.1.2", + "version": "3.5.6", + "resolved": "https://registry.npmjs.org/axe-core/-/axe-core-3.5.6.tgz", + "integrity": "sha512-LEUDjgmdJoA3LqklSTwKYqkjcZ4HKc4ddIYGSAiSkr46NTjzg2L9RNB+lekO9P7Dlpa87+hBtzc2Fzn/+GUWMQ==", "dev": true, - "hasInstallScript": true, - "license": "MPL-2.0", "engines": { "node": ">=4" } }, "node_modules/axe-puppeteer": { - "version": "1.0.0", + "version": "1.1.1", + "resolved": "https://registry.npmjs.org/axe-puppeteer/-/axe-puppeteer-1.1.1.tgz", + "integrity": "sha512-bU7dt3zlXrlTmaBsudeACEkQ0O4a5LNxRCdA1Qfph4mqx/DewybPCrlyDqJlHXb/W7ZSodE1fMmC+MgRLizxuQ==", + "deprecated": "deprecated", "dev": true, - "license": "MPL-2.0", "dependencies": { - "axe-core": "^3.1.2" + "axe-core": "^3.5.3" }, "engines": { "node": ">=6.4.0" }, "peerDependencies": { - "puppeteer": "^1.10.0" + "puppeteer": ">=1.10.0" } }, "node_modules/axios": { diff --git a/package.json b/package.json index 5d792b33e4..a0bbbd0372 100644 --- a/package.json +++ b/package.json @@ -47,7 +47,7 @@ "@metalsmith/permalinks": "^2.4.1", "@metalsmith/sass": "^1.2.0", "accessible-autocomplete": "^2.0.4", - "axe-puppeteer": "^1.0.0", + "axe-puppeteer": "^1.1.1", "fs-extra": "^10.1.0", "iframe-resizer": "^3.6.6", "jest": "^29.3.1", From 69e36484612809f7c3fedd6b0571289955973127 Mon Sep 17 00:00:00 2001 From: Brett Kyle Date: Wed, 30 Nov 2022 22:09:22 +0000 Subject: [PATCH 2/2] Fix Axe audit issues --- __tests__/accessiblity_audit.test.js | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/__tests__/accessiblity_audit.test.js b/__tests__/accessiblity_audit.test.js index b44a63344d..90fcf57f52 100644 --- a/__tests__/accessiblity_audit.test.js +++ b/__tests__/accessiblity_audit.test.js @@ -12,8 +12,15 @@ let baseUrl = 'http://localhost:' + PORT async function audit (page) { const axe = new AxePuppeteer(page) .include('body') - .exclude('#app-site-search__input') // axe reports there is "no label associated with the text field", when there is one. - .exclude('.app-phase-banner') // axe reports that the phase banner is not inside a landmark, which is intentional. + // axe reports there is "no label associated with the text field", when there is one. + .exclude('#app-site-search__input') + // axe reports that the phase banner is not inside a landmark, which is intentional. + .exclude('.app-phase-banner') + // axe reports that the skip link is not inside a landmark, which is intentional. + // https://design-system.service.gov.uk/components/skip-link/#when-to-use-this-component + .exclude('.govuk-skip-link') + // axe reports that the back to top button is not inside a landmark, which is intentional. + .exclude('.app-back-to-top') const results = await axe.analyze()