-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better align custom tab logic with tab component #385
Comments
https://trello.com/c/wF6tmFc1 will address better keyboard access but we're not doing the URL setting feature for now. |
Let's look at this as part of #677 |
I've investigated this by forking the tabs component and trying to get it to behave similar to the current application tabs component, my notes:
It would be possible to add features and such to the tabs component to make it work nicely but I'm wondering if we should close this as I'm not aware of any barriers for users and the effort to get them aligned is quite a lot? We could open specific actionable issues for this in the future if we find barriers for users. |
We think this is an inconsistency but not an accessibility issue in itself, therefore we are not going to prioritise this work at this time. |
Not sure if this issue covers this - but you cannot press the tab key, to get to other 'tabs' in the tab component. |
@matthewford The tabs component is navigated by pressing the arrow keys on the keyboard. Pressing the tab key shouldn't operate the tabs component but move the focus to the next element in the tab order. |
@hannalaakso Thanks, that works. |
This looks like tech debt to me; we should be using the tabs component from the Design System simply to reduce the maintenance burden of this repo. I've added the tech debt label. Edited to add: However, given that the impact of the debt is low and the effort to pay down is high, this is probably a low priority. |
The Tabs component in the Design System has features such as:
We should investigate getting the custom design system tabs to behave closer to the Tab component.
The text was updated successfully, but these errors were encountered: