Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better align custom tab logic with tab component #385

Open
NickColley opened this issue Jun 21, 2018 · 8 comments
Open

Better align custom tab logic with tab component #385

NickColley opened this issue Jun 21, 2018 · 8 comments
Labels
tabs tech debt website Issues relating to the Design System website itself

Comments

@NickColley
Copy link
Contributor

NickColley commented Jun 21, 2018

The Tabs component in the Design System has features such as:

  • better keyboard access

We should investigate getting the custom design system tabs to behave closer to the Tab component.

@hannalaakso
Copy link
Member

https://trello.com/c/wF6tmFc1 will address better keyboard access but we're not doing the URL setting feature for now.

@dashouse
Copy link

dashouse commented Jan 9, 2019

Let's look at this as part of #677

@NickColley
Copy link
Contributor Author

NickColley commented Aug 5, 2019

I've investigated this by forking the tabs component and trying to get it to behave similar to the current application tabs component, my notes:

  • need to remove the 'contents' heading for mobile
  • need to remove 'unenhanced' mobile view, since it'd be too much content to show everything expanded
  • remove hash url stuff since it doesnt work that well with multiple tabs on one page.

It would be possible to add features and such to the tabs component to make it work nicely but I'm wondering if we should close this as I'm not aware of any barriers for users and the effort to get them aligned is quite a lot?

We could open specific actionable issues for this in the future if we find barriers for users.

@NickColley NickColley added the awaiting triage Needs triaging by team label Aug 5, 2019
@kellylee-gds
Copy link
Contributor

We think this is an inconsistency but not an accessibility issue in itself, therefore we are not going to prioritise this work at this time.

@kellylee-gds kellylee-gds removed the awaiting triage Needs triaging by team label Aug 7, 2019
@matthewford
Copy link

matthewford commented Jun 4, 2020

Not sure if this issue covers this - but you cannot press the tab key, to get to other 'tabs' in the tab component.

@hannalaakso
Copy link
Member

@matthewford The tabs component is navigated by pressing the arrow keys on the keyboard. Pressing the tab key shouldn't operate the tabs component but move the focus to the next element in the tab order.
I hope this helps but let us know if I've misunderstood your issue.

@matthewford
Copy link

@hannalaakso Thanks, that works.

@lfdebrux
Copy link
Member

lfdebrux commented May 17, 2021

This looks like tech debt to me; we should be using the tabs component from the Design System simply to reduce the maintenance burden of this repo. I've added the tech debt label.

Edited to add: However, given that the impact of the debt is low and the effort to pay down is high, this is probably a low priority.

@36degrees 36degrees added the website Issues relating to the Design System website itself label Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tabs tech debt website Issues relating to the Design System website itself
Projects
None yet
Development

No branches or pull requests

9 participants