Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review hybrid Password component decision using Text Input with before/after content #3479

Closed
1 task
calvin-lau-sig7 opened this issue Jan 29, 2024 · 1 comment
Assignees

Comments

@calvin-lau-sig7
Copy link
Contributor

calvin-lau-sig7 commented Jan 29, 2024

Decide what will be built for the Password Input component, and how it fits in with other component parts.

Includes: Review putting toggle button in template (vs JavaScript)

What

Why

Who needs to work on this

Who needs to review this

Done when

  • Thing to do
@calvin-lau-sig7 calvin-lau-sig7 added epic Epics are used in planning project boards to group related stories and removed epic Epics are used in planning project boards to group related stories labels Jan 29, 2024
@calvin-lau-sig7 calvin-lau-sig7 moved this to Backlog 🏃🏼‍♀️ in GOV.UK Design System cycle board Jan 29, 2024
@colinrotherham colinrotherham changed the title Review decision not to extend Text Input in light of before/after HTML feature Review hybrid Password component decision using Text Input with before/after content Feb 7, 2024
@querkmachine
Copy link
Member

Given the changes since made to the main branch to make components easier to extend (e.g. #4567, #4742), we're now more comfortable having the Password input component inherit the Input component, rather than implementing it as a separate entity.

This approach was spiked in #4741 and #4746, where we validated that this approach would be practical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants