-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Summary list #182
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@NickColley @dashouse @amyhupe We are going to use this code for our add to list pattern but in our pattern there is no key-value pair. There is just a value used for the We thought about using a |
Or is there a way of grouping all the
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
We've updated the summary list component recently:
Make sure you're on version 2.7.0 of GOV.UK Frontend to get these improvements. Update: v2.8.0 has even better support for word wrapping so please upgrade to 2.8.0 :) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
We've had a contribution so that people can remove the visited state from the action (Change) links. We've decided to merge this so service teams can add classes manually but are interested if we could improve any guidance based around this. You can read how they got on here: alphagov/govuk-frontend#1233 (comment) |
The intermediate I'm curious to know whether this intermediate element is considered a spec violation. If not I will report issue to Deque and suggest they relax their validation rules to check for a
|
@tmakin Thanks for the comment. The issue is being flagged on an old version of the spec, a You'll find a few of issues raised about this on aXe and other validatiors. We suggest omitting from your tests or making a note to ignore it. |
@dashouse Many thanks, that reference clears things up. Looks like axe are on the case already: |
I can possibly provide an empty array to |
I added a pr to fix the empty ul - #1259 |
I wonder if we could have a new component (or alt version of this one) for simplified key-value pair display. Right now I think many services / teams will be using separate paragraphs for each item - I suspect key-value pair with description lists would be more appropriate. Some examples: Service manualGOV.UKThis sort of display is often used for 'metadata' type information about a page / service / piece of content. |
Hello 👋 we're implementing a design that's based on the summary list pattern: We can accomplish this by passing something like this to the summary list: items: {
field: index + 1,
value: sanitize(
"<h4 class='govuk-heading-s govuk-!-margin-bottom-0'>#{attachment.title}</h4>"\
"#{render('components/attachment_meta')}"
)
} However, that's quite ugly/brittle - and I do have misgivings about the rendered HTML. Currently the output would be something like this: <dl>
<dt>1</dt>
<dd><h4>Foo</h4>Unique ref</dd>
</dl> Semantically, it should just be an ordered list: <ol>
<li><h4>Foo</h4>Unique ref</li>
</ol> The summary list component doesn't tie itself to the description list/terms/descriptions markup - at least not by name - so in theory there's nothing stopping us rendering an @benthorner & I were wondering if there's a need here that the summary list component isn't currently meeting, and could be expanded to support? For example, we also use numbers as keys in Collections Publisher, although sometimes we use words like "AND" or "OR", so it's not quite as straightforward. We're proposing, for consideration, an optional numbered: true,
items: {
field: attachment.title,
value: render('components/attachment_meta')}
} The Would this be worth considering including in the design system? |
Thanks @ChrisBAshton and @benthorner - It's an interesting use case that that we'd not considered. We'd need to see some more evidence of a need for this from other teams I think, before we considered supporting it. |
I'd like to request a style change/option to the summary list component, to have the first column be 33.3333% in width instead of 30%. This would make it easier to have other content around the summary list be visually aligned with it. Currently if you have things such as cards above the summary list, you can't use the grid system to align the "seams". |
When using the summary list without actions there is a lot of space left on the right hand side. Could the other columns use this available space to wrap their content less? |
@chris-weston Thanks for your comment. You can customise the widths of columns in the summary list using the width override classes. We have an open issue to document in the Design System website how to do this: alphagov/govuk-design-system#1196 (the issue links to the table component that shows an example you can use to do this in the summary list). Feel free to comment on that issue if you have any thoughts on it. |
Hi @hannalaakso thanks for the reply, yes I did try using 'govuk-!-width-one-half' on the key in my row, but it seemed as though it was something that could be added at the row level, or even the summaryList level to apply it to all. |
A discussion on slack has just arisen about adjusting the width in the summary list. A similar discussion about 'Check answers' resulted in an update to guidance: alphagov/govuk-design-system#1835 Can that update also be applied to the summary list guidance? |
On 31 January 2023, we released the Summary card as a new variant within the Summary list component. See the release notes for GOV.UK Frontend v4.5.0 to find out more. |
@joelanman When will the updates implemented into v4.5.0, specifically around the summary cards for multiple lists, be implemented into the prototyping kit? Sorry if it is in there, but struggling to get the styling to appear like it does on the Summary List components page. |
@barry-moj in v13, Frontend is a plugin, you can update it in Manage Prototype > Plugins. In v12, you have to update the version in |
Cheers Joe! |
We ran an external accessibility audit for some of the components and patterns in GOV.UK Frontend in May 2023. In that audit, we included an example of the Summary list (card) component. We’re adding results from that audit here so that we can:
Two accessibility issues raisedIssue 1: WCAG ADelete work history' isn't specifying for which card it applies
More detail in this issue: Issue 2: WCAG A'Change [row heading]' link doesn't give full context for the summary card it applies to
More detail in this issue: |
Hi. As I understand it, this new statement on WCAG 2.2 guidelines should be an 'OR' statement, rather than 'AND'. For example: "...are at least 24px by 24px in size, or have adequate spacing" Because in this case, the action links in the component examples have a height of 23px so they are not "at least 24px by 24px in size". ...but they do meet the WCAG 'spacing' exception:
|
Hello, With the addition of multiple action links, I have noticed that on a two-thirds column layout, the links stack when the viewport width is 1280 CSS pixels wide and the page is zoomed to 150%. The WCAG 2.2 success criterion 2.5.8 Target Size (minimum) is met. Would you consider revising the 20% width set for .govuk-summary-list__actions {
width: 20%;
text-align: right;
} Obviously this is dependant on the text length of the links. The HMRC Add to a list pattern handles this although they only have 2 description values. |
Hi all. I was designing a "review and submit" page to have at the end of a application review journey. The user would go through and review several different pieces of information and select to confirm or query the information. We had a few iterations on this before we got it right. We needed a way of detaching the change action from the information and attaching it to the confirmation value. In the end we made two tweak to the standard summary card component. When retesting this, we could confirm that our users no longer believed they could update the information, but instead expected to be able to change the 'yes/no' value that they selected throughout the journey. We had managed to attach the change action to the value and detach it from the information. So we would like for this customisation to be added into the component as a valid option as these two small changes completely changed how our users viewed the component and their expectation to the change action. It would be interesting if anyone has had a similar requirement and how you solved it. |
Use this issue to discuss the summary list component.
The text was updated successfully, but these errors were encountered: