Network - options object unexpectedly modified by network.setOptions

[rjbriody]

Hello.

The options object is being unexpectedly modified to invalid options when calling network.setOptions.

https://jsfiddle.net/4jtopnmj/4/

To reproduce:

• Double-click a node. This will use a 2nd set of options that specify hierarchical layout.
• Double click the canvas to switch back to the original options. 2 things go wrong here:
  • The edge smooth is still cubicBezier in the graph, but should be continuous. This is pretty clearly a symptom of the 2nd problem...
  • If you look at the console output then you will see that the smooth config is altered during network.setOptions.

[AlexDM0]

Hi,

the hierarchical layout is altering the options but it seems the reverting is not done correctly.

Well look into this. Thank you for reporting!

Regards

On 16 Feb 2016, at 01:54, bobb notifications@github.com wrote:

Hello.

The options object is being unexpectedly modified to invalid options when calling network.setOptions.

https://jsfiddle.net/4jtopnmj/4/

To reproduce:

Double-click a node. This will use a 2nd set of options that specify hierarchical layout.
Double click the canvas to switch back to the original options. 2 things go wrong here:
The edge smooth is still cubicBezier in the graph, but should be continuous. Which is pretty clearly a symptom of the 2nd problem...
If you look at the console output then you will see that the smooth config is altered during network.setOptions.
—
Reply to this email directly or view it on GitHub.

[lftakakura]

same here

[mojoaxel]

I'm closing this issue due to inactivity.
If you think this issue is still relevant please feel free to reopen!

[rjbriody]

This is still relevant. My uninformed opinion is that it seems like vis.js should clone the incoming settings object upon reception so that any intentional or accidental modifications to the settings are not leaked back to the user object being passed in.

[wimrijnders]

I agree, opening it again.