Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] alloy-consensus should use alloy_primitives::Sealable #1071

Closed
Wollac opened this issue Jul 18, 2024 · 1 comment · Fixed by #1072
Closed

[Bug] alloy-consensus should use alloy_primitives::Sealable #1071

Wollac opened this issue Jul 18, 2024 · 1 comment · Fixed by #1072
Assignees
@zerosnacks
Labels
bug Something isn't working

Comments

@Wollac
Copy link
Contributor

Wollac commented Jul 18, 2024

Component

consensus, eips, genesis

What version of Alloy are you on?

alloy-consensus v0.2.0

Operating System

None

Describe the bug

There are currently two versions of Sealable/Sealed. One that lives in alloy-consensus and one in alloy-primitives. This should be consolidated and the more general alloy-primitives crate used.
@Wollac Wollac added the bug Something isn't working label Jul 18, 2024
@mattsse
Copy link
Member

mattsse commented Jul 18, 2024

thanks for pointing this out, fully agree

@zerosnacks do you want to take this?

@zerosnacks zerosnacks self-assigned this Jul 18, 2024
@zerosnacks zerosnacks mentioned this issue Jul 18, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zerosnacks zerosnacks

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bug: alloy-consensus should use alloy_primitives::Sealable alloy-rs/alloy
3 participants
@Wollac @mattsse @zerosnacks