Skip to content
This repository has been archived by the owner on Jul 19, 2023. It is now read-only.

Prevent using actions/setup-java@v3 with adopt distribution #26

Closed
OriYosef opened this issue Sep 1, 2022 · 6 comments
Closed

Prevent using actions/setup-java@v3 with adopt distribution #26

OriYosef opened this issue Sep 1, 2022 · 6 comments
Assignees
Labels
good first issue Good for newcomers rule requests Requests for new rule

Comments

@OriYosef
Copy link
Contributor

OriYosef commented Sep 1, 2022

NOTE: Adopt OpenJDK got moved to Eclipse Temurin and won't be updated anymore. It is highly recommended to migrate workflows from adopt to temurin to keep receiving software and security updates. See more details in the Good-bye AdoptOpenJDK post.

@OriYosef OriYosef added the rule requests Requests for new rule label Sep 1, 2022
@itaiperi
Copy link
Member

itaiperi commented Sep 1, 2022

What about earlier versions than v3? or any sha?
In other words - does this apply to setup-java for all its versions, or just v3?

@OriYosef
Copy link
Contributor Author

OriYosef commented Sep 1, 2022

V1 doesn't support choosing a distribution version. About V2 it is not clear.
Please check out this source

@idanshahar idanshahar added the good first issue Good for newcomers label Sep 5, 2022
@jmj0502
Copy link
Contributor

jmj0502 commented Sep 27, 2022

Hey! I would like to work on this issue. However, I'll need some details in regard to what changes should be made to the code (EG: files, functions, etc.), in order to meet the expected behavior.

@OriYosef
Copy link
Contributor Author

Hey, @jmj0502, we appreciate your offer to contribute and you are more than welcome!
Please check out how to contribute by the README file.
Prevent using action/setup-java will be implemented as a rule. A rule is a yaml file that includes Json schema that validates the desired behavior. Please see the examples here.
In addition to the schema you need to add a description, failureMessage, uniqueId and enabledByDefault keys as in all other rules.
Last, you need to add a similar rule (a yaml file) for Gitlab pipelines here. In your case, because setup-java action does not exist for .gitlab-ci.yaml files so the schema value should be empty as here

@jmj0502
Copy link
Contributor

jmj0502 commented Sep 29, 2022

@OriYosef Cool! I'll give a shot. I'll reach out in case I have any questions 👍

@dimabru
Copy link
Contributor

dimabru commented Oct 6, 2022

closed in #82

@dimabru dimabru closed this as completed Oct 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers rule requests Requests for new rule
Projects
None yet
Development

No branches or pull requests

5 participants