Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra JSON.stringify in event bus publisher #4862

Open
coderabbitai bot opened this issue Jan 23, 2025 · 0 comments
Open

Remove extra JSON.stringify in event bus publisher #4862

coderabbitai bot opened this issue Jan 23, 2025 · 0 comments

Comments

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 23, 2025

The event bus publisher has an extra JSON.stringify statement that causes consumers to perform double JSON.parse. This affects multiple components including the VC Engine library and other engines.

References

Impact

  • Requires double JSON.parse in consumers
  • Affects VC Engine library and other engines
  • Makes the code harder to understand and maintain

Required Changes

  1. Remove the extra JSON.stringify in the event bus publisher
  2. Update VC Engine library to handle the change
  3. Update other engines to handle the change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants