Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show subspace events in Space #6876

Closed
4 of 5 tasks
SimoneZaza opened this issue Sep 13, 2024 · 3 comments
Closed
4 of 5 tasks

Show subspace events in Space #6876

SimoneZaza opened this issue Sep 13, 2024 · 3 comments
Assignees
Labels
Atlas Team Issues and Epics worked on by team Atlas client server user story

Comments

@SimoneZaza
Copy link
Contributor

SimoneZaza commented Sep 13, 2024

Description

As a subspace admin, I want to be able to promote some events on the Space level as well.
As a space admin, I want to be able to prevent subspace events from being promoted on the space dashboard

Acceptance criteria

Space settings to (dis)allow subspace events to be shown in space calendar

  • In the Allowed Actions on Space/Subspace l1 > Settings > Settings, add
  • Subspace events: Allow events from Subspaces to be published on this calendar as well
  • as per design
  • Should be on by default

Switch on event create/update dialog to show subspace event in space

  • At the bottom of the screen (above the footer with the buttons), add switch
  • Text: Also visible on <title parent (sub)space> Calendar
  • Default off

Updated show event dialog with space/subspace title

  • In the dialog with the list of events, show Space/Subspace title of the event in the header of the event, on the right of the time
  • In the dialog per event, show Space/Subspace title of the event in the header of the event, below the time (See design, difficult to explain)

Additional Context

Design

https://www.figma.com/design/rddyv3LBg0sbm1b7Yny9ze/Calendar-V3?node-id=158-530&t=kMt4Dx0dO30ikqke-1

Comments on related server issue (old, replaced by this issue):

  • In which of the 3 blocks would this setting be found? - I believe Allowed Actions fits best
  • a new field for this setting needs to be added
  • a new column is required to indicate the visibility of the event
  • how deep do we want to display events - level 1 or further? Let's keep it at one level up for simplicity for now
  • if I assume the subspace event will be visible when the root Space events are queried, a new field should be added to indicate this event is not part of the Space events
  • Can a non-member still see the events if the subspace is private and both settings are enabled? Preferably yes, but if this is adding complexity then please leave it as is for now, but inform product team
@SimoneZaza SimoneZaza changed the title Copy of Multiple/all day events: Display in calendar dialog Subspace events shown in Spaces: Space settings Sep 13, 2024
@SimoneZaza SimoneZaza added the Rhea Team Issues and Epics worked on by team Rhea label Oct 21, 2024
@SimoneZaza SimoneZaza changed the title Subspace events shown in Spaces: Space settings Show subspace events in Space Oct 31, 2024
@SimoneZaza SimoneZaza removed the Rhea Team Issues and Epics worked on by team Rhea label Oct 31, 2024
@SimoneZaza SimoneZaza added server Atlas Team Issues and Epics worked on by team Atlas labels Oct 31, 2024
@hero101
Copy link
Collaborator

hero101 commented Oct 31, 2024

Between 5 and 8 depending on how deep into the Space we want to go. TBD with @SimoneZaza about the exact behavior.
It could take less than a day based on the above.

Update: Only L0 has the setting and displays all events checked to bubble on L1.

@Comoque1
Copy link
Member

Comoque1 commented Nov 12, 2024

Tested on ACC env.
Findings are as follows:

  1. Events from private subspaces are not visible on Space level (above is written, that if there is complexity it is acceptable)
  2. Unauthenticated user can see comments and users on events of Public space / Subspace: Bug
  3. Only Subspace L1 events are visible on Space level - as per AC
  4. "Also visible on the parent Space calendar" button is visible on Subspace Level2: Bug
  5. The point: In the dialog per event, show Space/Subspace title of the event in the header of the event, below the time (See design, difficult to explain) - the point is moved in separate story image.png

Test results in document related to auth.

@Comoque1
Copy link
Member

@SimoneZaza if you accept the above feedback, we can close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Atlas Team Issues and Epics worked on by team Atlas client server user story
Projects
None yet
Development

No branches or pull requests

3 participants