From a35637d6b59195787e25fc9a85ffedbf3e267b77 Mon Sep 17 00:00:00 2001 From: Mark Chappell Date: Mon, 14 Mar 2022 15:20:07 +0100 Subject: [PATCH] Various integration test fixes (#984) Various integration test fixes SUMMARY Updates the version of Python used by lambda in the lambda_alias, lambda_policy and aws_secret integration tests Updates the version of NodeJS used by the lambda in the lamba integration tests Adds a retry to the s3_bucket_notification tests, permissions are sometimes a little slow to update Cleans up Snapshots from rds_instance integration tests Disables broken WAFv2 integration test (#985) Fixes: #976 ISSUE TYPE Bugfix Pull Request COMPONENT NAME aws_secret lambda lambda_alias lambda_policy rds_policy s3_bucket_notification wafv2 ADDITIONAL INFORMATION Amazon appear to have dropped support for creating Python2.7 lambdas: botocore.errorfactory.InvalidParameterValueException: An error occurred (InvalidParameterValueException) when calling the CreateFunction operation: The runtime parameter of python2.7 is no longer supported for creating or updating AWS Lambda functions. We recommend you use the new runtime (python3.9) while creating or updating functions. Reviewed-by: Alina Buzachis This commit was initially merged in https://github.com/ansible-collections/community.aws See: https://github.com/ansible-collections/community.aws/commit/c5e464000b35111f000fe2e1c44c39cbeffdc76b --- .../rds_instance/roles/rds_instance/tasks/test_tagging.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/integration/targets/rds_instance/roles/rds_instance/tasks/test_tagging.yml b/tests/integration/targets/rds_instance/roles/rds_instance/tasks/test_tagging.yml index bb84a63d95d..16511f4ac6f 100644 --- a/tests/integration/targets/rds_instance/roles/rds_instance/tasks/test_tagging.yml +++ b/tests/integration/targets/rds_instance/roles/rds_instance/tasks/test_tagging.yml @@ -143,9 +143,9 @@ - "result.snapshots.0.engine == 'mariadb'" always: - - name: remove snapshot + - name: remove final snapshot rds_instance_snapshot: - db_snapshot_identifier: "{{ tiny_prefix }}-test-snapshot" + db_snapshot_identifier: "{{ instance_id }}" state: absent wait: false ignore_errors: yes