Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Added new options #413

Merged
merged 3 commits into from
Mar 26, 2019
Merged

[CLI] Added new options #413

merged 3 commits into from
Mar 26, 2019

Conversation

simogasp
Copy link
Member

@simogasp simogasp commented Mar 7, 2019

This PR introduces two main options to the command line scripts.

  • meshroom_photogrammetry, a --overrides parameter is added that enables the user to specify a json file containing parameters values to use for each node, thus overriding the default settings. The json file follows a similar structure of the .mg file containing the pipeline, ie:
{
        "<node1Name>": {
                "<param1Name>": "<param1Value>"
                "<param2Name>": "<param2Value>"
        },
        "<node2Name>": {
                 "<param1Name>": "<param1Value>"
        },
...
}

For example one file setting file settings.json could be

{
        "FeatureExtraction_1": {
                "describerPreset": "high"
        },
        "FeatureMatching_1": {
                "guidedMatching": "0"
        },
        "StructureFromMotion_1": {
                "useLocalBA": "0",
                "refineIntrinsics": "0"
        }
}
  • ui can now take a parameter --pipeline --project that enables the user to specify a project file to load, i.e.
python meshroom/ui --project myProject.mg

Moreover, it add the possibility for the node PrepareDenseScene to export the list of undistorted images so they can, eg, published with the Publish node. This is because there was no other way of export the images since the suppression of the node ExportUndistortedImages (490ebfe)

The user can specify a json file to override the default parameter of
each node.
@yann-lty yann-lty merged commit 1cb9935 into develop Mar 26, 2019
@yann-lty yann-lty deleted the dev_CLIoptions branch March 26, 2019 14:53
@fabiencastan fabiencastan added this to the Meshroom 2019.2.0 milestone Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants