Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Fix graph axes naming for ram statistics #1033

Merged
merged 2 commits into from
Aug 24, 2020
Merged

[ui] Fix graph axes naming for ram statistics #1033

merged 2 commits into from
Aug 24, 2020

Conversation

ChemicalXandco
Copy link
Contributor

Description

Before this change, the graph for the ram statistics used gigabytes as the unit, but the actual value is in percent.

Features list

  • ram graph now uses % instead of gigabytes
  • refactoring of the id names of ValueAxis items to be more readable e.g. valueAxisY3 -> valueGpuY

@fabiencastan
Copy link
Member

fabiencastan commented Aug 24, 2020

It gives me:

Qt Quick Layouts: Detected recursive rearrange. Aborting after two iterations.

This warning appears when we open the "Statistics" tab, but it has not been introduced in this PR. It is already there in the "develop" branch.
I'm testing that on linux with Qt 5.14.2.

@fabiencastan
Copy link
Member

@fabiencastan fabiencastan added this to the Meshroom 2020.1.0 milestone Aug 24, 2020
@fabiencastan fabiencastan changed the title Bug: fix ram statistics graph [ui] Fix graph axes naming for ram statistics Aug 24, 2020
@fabiencastan fabiencastan merged commit 9211434 into alicevision:develop Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants